fix(settings): display birthday correctly regardless of browsers timezone#61586
Merged
Conversation
odzhychko
force-pushed
the
BirthdaySection-timezone
branch
from
9370ac9 to
08e0100
Compare
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
odzhychko
requested review from
nfebe,
sorbaugh and
susnux
and removed request for
a team
susnux
reviewed
Jun 25, 2026
susnux
reviewed
Jun 25, 2026
susnux
reviewed
Jun 25, 2026
susnux
reviewed
Jun 25, 2026
odzhychko
force-pushed
the
BirthdaySection-timezone
branch
from
08e0100 to
6cdae3c
Compare
odzhychko
force-pushed
the
BirthdaySection-timezone
branch
from
6cdae3c to
48c4621
Compare
susnux
approved these changes
Jul 1, 2026
susnux
left a comment
susnux
left a comment
Contributor
There was a problem hiding this comment.
maybe this should be a shared composable in nc-vue
skjnldsv
approved these changes
Jul 1, 2026
`savePrimaryAccountProperty` does only allow `string | boolean`. Incidentally, relying on `@nextcloud/axios` default serialization, `Date`s where serialized using `toISOString`. See https://github.com/axios/axios/blob/a7d7a714498452e611943d9d8e5c2ed8b00aa6b9/lib/helpers/toFormData.js#L134 This change corrects the usage of `savePrimaryAccountProperty` and makes serialization explicit. Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
…zone This also avoid shifting dates after user input. Resolves #49828 Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
odzhychko
force-pushed
the
BirthdaySection-timezone
branch
from
48c4621 to
33ac293
Compare
odzhychko
added
4. to release
Contributor
Author
Don't know if this is a common enough issue. |
This was referenced Jul 2, 2026
Contributor
Author
|
/backport to stable34 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Display birthday correctly regardless of browsers timezone.
Before
Screen.Recording.2026-06-25.at.09.48.23.mov
After
Screen.Recording.2026-06-25.at.09.50.04.mov
Checklist
3. to review, feature component)stable32)