Skip to content

fix(core): resolve some edge cases with recommended apps#61663

Open
susnux wants to merge 3 commits into
masterfrom
fix/recommended-apps-2
Open

fix(core): resolve some edge cases with recommended apps#61663
susnux wants to merge 3 commits into
masterfrom
fix/recommended-apps-2

Conversation

@susnux

@susnux susnux commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

There are some edge cases to keep in mind:

  1. Not always install the code server if office is not installed
  2. Handle installed apps properly
  3. Properly handle aborted password confirmation

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@susnux susnux requested a review from a team as a code owner June 29, 2026 17:05
@susnux susnux requested review from a team, nfebe, pringelmann, skjnldsv and sorbaugh and removed request for a team June 29, 2026 17:05
@susnux susnux added 3. to review Waiting for reviews bug labels Jun 29, 2026
@susnux susnux added this to the Nextcloud 35 milestone Jun 29, 2026
@pringelmann

pringelmann commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

setup.ts has been failing on master since #61575. The "Install recommended apps" cases still stub the old endpoints so the intercepts no longer match.

Could be folded in here since you already touch this flow. Happy to pick it up if you're busy, just let me know.

@pringelmann

pringelmann commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@susnux The per-app enable loop here reintroduces multiple password prompts. #60068 switched install to a single bulk enable specifically so strict confirmation only prompts once. Installing N recommended apps now pops N password dialogs.

That's also why the setup.ts Cypress spec is red: it expects one bulk enable + one dialog.

How do you want to handle it?

@susnux

susnux commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

How do you want to handle it?

Sounds like we should bring that back, but that needs backend changes now.
Lets do that in a follow up.

But the cypress test I can adjust here for now.

@joshtrichards

joshtrichards commented Jun 30, 2026

Copy link
Copy Markdown
Member

Related bug: #32310

@odzhychko odzhychko mentioned this pull request Jul 2, 2026
Closed
8 tasks
susnux added 2 commits July 3, 2026 00:13
@susnux
fix(core): resolve some edge cases with recommended apps
54bc573 
There are some edge cases to keep in mind:
1. Not always install the code server if office is not installed
2. Handle installed apps properly
3. Properly handle aborted password confirmation

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
test(cypress): fix setup tests for recommended apps
d176b42 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/recommended-apps-2 branch from 5e0827c to d176b42 Compare July 3, 2026 00:10
@susnux

susnux commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

/compile

@nextcloud-command
chore(assets): Recompile assets
90bc4f7 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pringelmann pringelmann pringelmann approved these changes
@skjnldsv skjnldsv skjnldsv approved these changes
@CarlSchwan CarlSchwan CarlSchwan approved these changes
@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend
@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-frontend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

[Bug]: Nextcloud doesn't check system requirements for recommended apps

6 participants

@susnux @pringelmann @joshtrichards @skjnldsv @CarlSchwan @nextcloud-command