fix(UserPlugin): Don't return disabled users on user ID and mail match#61984
Open
DerDreschner wants to merge 1 commit into
Open
fix(UserPlugin): Don't return disabled users on user ID and mail match#61984DerDreschner wants to merge 1 commit into
DerDreschner wants to merge 1 commit into
Conversation
Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
DerDreschner
requested review from
nfebe and
sorbaugh
and removed request for
a team
DerDreschner
force-pushed
the
fix/dont-return-disabled-users
branch
2 times, most recently
from
ced4e42 to
40c0848
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disabled users are supposed to be hidden when using the share API. This isn't the case right now for two code branches: user ID match and email address match.
This is being fixed by this PR to make the behavior consistent. I've also added integration tests to ensure it doesn't change in the future (until it's being changed on-purpose).
Checklist
3. to review, feature component)stable32)AI (if applicable)