Skip to content

fix: manage existing breakout rooms from conversation settings #16728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Antreesy wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: manage existing breakout rooms from conversation settings #16728

Antreesy wants to merge 3 commits into from

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 15, 2026

☑️ Resolves

  • Fix Add additional breakout rooms #16726
    • Already configured rooms should show the participants editor / manager to move them across rooms, or delete all rooms
    • Logic, styles and strings copied from Right sidebar > Breakout rooms action
    • Modals are now mounted inside the conversation settings dialog - so should not be behind

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🍏 Next Beta (33) milestone Jan 15, 2026
@Antreesy Antreesy requested review from ShGKme and Copilot January 15, 2026 10:03
@Antreesy Antreesy self-assigned this Jan 15, 2026
@Antreesy
Copy link
Contributor Author

Antreesy commented Jan 15, 2026

/backport to stable32

@Antreesy
Copy link
Contributor Author

Antreesy commented Jan 15, 2026

/backport to stable31

This comment was marked as resolved.

Sign in to view

@Antreesy
fix: manage existing breakout rooms from conversation settings
e04a13b 
- logic copied from BreakoutRoomsTab

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(BreakoutRoomsEditor): show nested modal on top of settings dialog
291b51f 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(BreakoutRoomsActions): remove non-existing prop
5759e7a 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/16726/manage-breakout-rooms branch from e9ac948 to 5759e7a Compare January 15, 2026 10:35
@Antreesy
Copy link
Contributor Author

Antreesy commented Jan 15, 2026

Great, I misclicked on PR creation and it's still following me 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ShGKme ShGKme Awaiting requested review from ShGKme

At least 1 approving review is required to merge this pull request.

Assignees

@Antreesy Antreesy

Labels

3. to review backport-request bug feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

🍏 Next RC (33)

Development

Successfully merging this pull request may close these issues.

Add additional breakout rooms

3 participants

@Antreesy @nickvergessen