Skip to content

WIP receive chat message from HPB #5635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
mahibi wants to merge 24 commits into
base: master
Choose a base branch
from
Draft

WIP receive chat message from HPB #5635

mahibi wants to merge 24 commits into from

Conversation

@mahibi
Copy link
Collaborator

@mahibi mahibi commented Dec 10, 2025 •
edited
Loading

resolve #5633

WIP

TODO

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi added this to the 23.0.0 milestone Dec 10, 2025
@mahibi mahibi self-assigned this Dec 10, 2025
@mahibi mahibi force-pushed the feature/5633/chatRelay branch 2 times, most recently from 074dc73 to 2d34ff3 Compare December 15, 2025 16:57
@mahibi mahibi modified the milestones: 22.1.0, 23.0.0 Dec 18, 2025
@mahibi mahibi force-pushed the feature/5633/chatRelay branch 2 times, most recently from ab134d2 to 3127450 Compare December 19, 2025 20:32
@mahibi mahibi added the 2. developing Work in progress label Dec 19, 2025
@mahibi mahibi force-pushed the feature/5633/chatRelay branch from 3127450 to f50377e Compare January 5, 2026 10:37
mahibi added 20 commits January 19, 2026 16:05
@mahibi
WIP receive chat message from HPB
1daffb4 
for now, directly passed to ChatActivity and just log it without further processing

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
prepare refactor
6ae1ac1 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
Rename .java to .kt
09b4be4 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
migrate SignalingMessageReceiver to kotlin
0434e2e 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
parse ChatMessage in SignalingMessageReceiver
0ef3539 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
show chat messages from signaling (temp. disabled longpolling for now)
e001809 
known issues:
mark chat as read not working (have to use separate endpoint to mark as read)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
WIP mark chat as read
bd15779 
wip:
Maybe trigger it when the user scrolled to the bottom on his own.
E.g. when a scrolling listener tells "scrolling is finished" we check if it's scrolled to the bottom and then send the mark as read

also todo:
mark as read "when the user is sending the app to the background or navigates "back to conversation list" and the last message a user read (saw on screen) is a higher id then the previous known readmarker"

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
implement new readMessage behavior
b54e304 
known issues: does not work well together with

val weHaveAtLeastTheLastReadMessage = newestMessageIdFromDb >= conversationModel.lastReadMessage.toLong()

for now. (Messages can be missing on initial load)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
identify problem for load of initial messages (add comment)
39fce80 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
handle loading of initial messages depending on HPB existence
11f627f 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
minor renaming and prepare insurance request
c305abf 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
migrate request to pull messages to flow/coroutine
264582e 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
add initRepeatingInsuranceRequest and refactor
cdf8312 
only an intermediate step

still needs refactoring so drawing of messages is not event based

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
show messages directly from database
6165108 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
use states ChatMessageViewState + avoid NPE (but also destroy viewing…
fd690b7 
… of images for now)

2026-01-13 17:42:16.895 25310-25310 AndroidRuntime          com.nextcloud.talk2                  D  Shutting down VM
2026-01-13 17:42:16.896 25310-25310 AndroidRuntime          com.nextcloud.talk2                  E  FATAL EXCEPTION: main (Explain with AI)
                                                                                                    Process: com.nextcloud.talk2, PID: 25310
                                                                                                    java.lang.NullPointerException
                                                                                                    	at com.nextcloud.talk.adapters.messages.PreviewMessageViewHolder.onBind(PreviewMessageViewHolder.kt:108)
                                                                                                    	at com.nextcloud.talk.adapters.messages.IncomingPreviewMessageViewHolder.onBind(IncomingPreviewMessageViewHolder.java:42)
                                                                                                    	at com.nextcloud.talk.adapters.messages.IncomingPreviewMessageViewHolder.onBind(IncomingPreviewMessageViewHolder.java:32)
                                                                                                    	at com.stfalcon.chatkit.messages.MessageHolders.bind(MessageHolders.java:596)
                                                                                                    	at com.stfalcon.chatkit.messages.MessagesListAdapter.onBindViewHolder(MessagesListAdapter.java:110)
                                                                                                    	at com.nextcloud.talk.adapters.messages.TalkMessagesListAdapter.onBindViewHolder(TalkMessagesListAdapter.java:84)
                                                                                                    	at com.nextcloud.talk.adapters.messages.TalkMessagesListAdapter.onBindViewHolder(TalkMessagesListAdapter.java:19)
                                                                                                    	at androidx.recyclerview.widget.RecyclerView$Adapter.onBindViewHolder(RecyclerView.java:7747)
                                                                                                    	at androidx.recyclerview.widget.RecyclerView$Adapter.bindViewHolder(RecyclerView.java:7847)
                                                                                                    	at androidx.recyclerview.widget.RecyclerView$Recycler.tryBindViewHolderByDeadline(RecyclerView.java:6646)
                                                                                                    	at androidx.recyclerview.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:6917)
                                                                                                    	at androidx.recyclerview.widget.GapWorker.prefetchPositionWithDeadline(GapWorker.java:288)
                                                                                                    	at androidx.recyclerview.widget.GapWorker.flushTaskWithDeadline(GapWorker.java:345)
                                                                                                    	at androidx.recyclerview.widget.GapWorker.flushTasksWithDeadline(GapWorker.java:361)
                                                                                                    	at androidx.recyclerview.widget.GapWorker.prefetch(GapWorker.java:368)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
WIP show messages directly from database (experimental)
b2102aa 
experimental for now.
contains a lot of wild experimenting and commented out code.
...because so much is going to change.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
include received message from signaling as newestMessageId in latest …
5bd114c 
…chat block

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
observeMessages with flatMapLatest
be1d7dc 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
observeMessages with flatMapLatest and filter out on database level
6c65fae 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
observeMessages with flatMapLatest and filter out on database level
e16b5bf 
clean up prior approaches

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
re add insurance call
f9345b0 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi force-pushed the feature/5633/chatRelay branch from f50377e to f9345b0 Compare January 19, 2026 15:06
mahibi added 3 commits January 19, 2026 18:04
@mahibi
handle system messages that needs to be persisted
a0b8426 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
comment out generalUIFlow and removeMessageFlow
8533d9d 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
refactor scope and regular message requests
36b3f6c 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5635.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2026

Codacy

Lint

TypemasterPR
Warnings9999
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5455
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8182

SpotBugs increased!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mahibi mahibi

Labels

2. developing Work in progress

Projects

None yet

Milestone

23.0.0

Development

Successfully merging this pull request may close these issues.

Chat relay via High-performance backend

2 participants

@mahibi