Skip to content

Implementing Media Controls for Voice Messages #6396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rapterjet2004 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implementing Media Controls for Voice Messages #6396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9424fbb
Migrating to ExoPlayer
rapterjet2004 Jun 23, 2026
9e7c818
Added a bunch of code to handle updates to the player, listen to stat…
rapterjet2004 Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ configurations.configureEach {
}

dependencies {
implementation("androidx.media3:media3-session:1.10.1")
kapt("org.jetbrains.kotlin:kotlin-metadata-jvm:$kotlinVersion")
implementation("androidx.room:room-testing-android:$roomVersion")
implementation("androidx.compose.foundation:foundation-layout:1.11.2")
Expand Down
10 changes: 10 additions & 0 deletions app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
<uses-permission android:name="android.permission.READ_CONTACTS" />
<uses-permission android:name="android.permission.WRITE_CONTACTS" />
<uses-permission android:name="android.permission.READ_PROFILE" />
<uses-permission android:name="android.permission.FOREGROUND_SERVICE_MEDIA_PLAYBACK"/>

<uses-permission android:name="android.permission.READ_SYNC_SETTINGS" />
<uses-permission android:name="android.permission.WRITE_SYNC_SETTINGS" />
Expand Down Expand Up @@ -329,6 +330,15 @@
android:resource="@xml/contacts" />
</service>

<service
android:name=".chat.data.io.VoiceMessageMediaService"
android:foregroundServiceType="mediaPlayback"
android:exported="true">
<intent-filter>
<action android:name="androidx.media3.session.MediaSessionService" />
</intent-filter>
</service>

<service
android:name=".utils.AuthenticatorService"
android:exported="false">
Expand Down
320 changes: 231 additions & 89 deletions app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt
View file
Open in desktop

Large diffs are not rendered by default.

171 changes: 93 additions & 78 deletions app/src/main/java/com/nextcloud/talk/chat/data/io/MediaPlayerManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,12 @@
*/

package com.nextcloud.talk.chat.data.io

import android.media.MediaPlayer
import android.util.Log
import androidx.media3.common.MediaItem
import androidx.media3.common.PlaybackParameters
import androidx.media3.common.Player
import androidx.media3.exoplayer.ExoPlayer
import com.nextcloud.talk.application.NextcloudTalkApplication
import com.nextcloud.talk.chat.ChatActivity
import com.nextcloud.talk.chat.data.model.ChatMessage
import com.nextcloud.talk.ui.PlaybackSpeed
Expand All @@ -28,6 +31,7 @@ import kotlinx.coroutines.withContext
import java.io.File
import java.io.FileNotFoundException
import kotlin.math.ceil
import kotlin.time.Duration.Companion.milliseconds

/**
* Abstraction over the [MediaPlayer](https://developer.android.com/reference/android/media/MediaPlayer) class used
Expand Down Expand Up @@ -81,7 +85,7 @@ class MediaPlayerManager : LifecycleAwareManager {
get() = _mediaPlayerSeekBarPosition
private val _mediaPlayerSeekBarPosition: MutableSharedFlow<Int> = MutableSharedFlow()

private var mediaPlayer: MediaPlayer? = null
private var mediaPlayer: ExoPlayer? = null
private var loop = false
private var scope = MainScope()

Expand All @@ -106,7 +110,7 @@ class MediaPlayerManager : LifecycleAwareManager {
init(path)
} else {
_managerState.value = MediaPlayerManagerState.RESUMED
mediaPlayer!!.start()
mediaPlayer!!.play()
loop = true
scope.launch { seekbarUpdateObserver() }
}
Expand All @@ -121,13 +125,13 @@ class MediaPlayerManager : LifecycleAwareManager {
stop()
}

val shouldReset = playQueue.first().first != currentDataSource
val shouldReset = playQueue.isNotEmpty() && playQueue.first().first != currentDataSource

if (mediaPlayer == null || !scope.isActive || shouldReset) {
initCycling()
} else {
_managerState.value = MediaPlayerManagerState.RESUMED
mediaPlayer!!.start()
mediaPlayer!!.play()
loop = true
scope.launch { seekbarUpdateObserver() }
}
Expand Down Expand Up @@ -171,46 +175,48 @@ class MediaPlayerManager : LifecycleAwareManager {
fun seekTo(progress: Int) {
if (mediaPlayer != null) {
val pos = mediaPlayer!!.duration * (progress / DIVIDER)
mediaPlayer!!.seekTo(pos.toInt())
mediaPlayer!!.seekTo(pos.toLong())
mediaPlayerPosition = pos.toInt()
}
}

private suspend fun seekbarUpdateObserver() {
_currentCycledMessage.value?.voiceMessageDuration = mediaPlayerDuration / ONE_SEC
_currentCycledMessage.value?.resetVoiceMessage = false
withContext(Dispatchers.IO) {
_currentCycledMessage.value?.voiceMessageDuration = mediaPlayerDuration / ONE_SEC
_currentCycledMessage.value?.resetVoiceMessage = false
while (true) {
if (!loop) {
// NOTE: ok so this doesn't stop the loop, but rather stop the update. Wasteful, but minimal
delay(SEEKBAR_UPDATE_DELAY)
delay(SEEKBAR_UPDATE_DELAY.milliseconds)
continue
}

mediaPlayer?.let { player ->
try {
if (!player.isPlaying) return@let
} catch (e: IllegalStateException) {
Log.e(TAG, "Seekbar updated during an improper state: $e")
return@let
}
withContext(Dispatchers.Main) {
mediaPlayer?.let { p ->
try {
if (!p.isPlaying) return@let
} catch (e: IllegalStateException) {
Log.e(TAG, "Seekbar updated during an improper state: $e")
return@let
}

val pos = player.currentPosition
mediaPlayerPosition = pos
val progress = (pos.toFloat() / mediaPlayerDuration) * DIVIDER
val progressI = ceil(progress).toInt()
val seconds = (pos / ONE_SEC)
_mediaPlayerSeekBarPosition.emit(progressI)
_currentCycledMessage.value?.let { msg ->
msg.isPlayingVoiceMessage = true
msg.voiceMessageSeekbarProgress = progressI
msg.voiceMessagePlayedSeconds = seconds
if (progressI >= IS_PLAYED_CUTOFF) msg.wasPlayedVoiceMessage = true
_mediaPlayerSeekBarPositionMsg.emit(msg)
val pos = p.currentPosition
mediaPlayerPosition = pos.toInt()
val progress = (pos.toFloat() / mediaPlayerDuration) * DIVIDER
val progressI = ceil(progress).toInt()
val seconds = (pos / ONE_SEC).toInt()
_mediaPlayerSeekBarPosition.emit(progressI)
_currentCycledMessage.value?.let { msg ->
msg.isPlayingVoiceMessage = true
msg.voiceMessageSeekbarProgress = progressI
msg.voiceMessagePlayedSeconds = seconds
if (progressI >= IS_PLAYED_CUTOFF) msg.wasPlayedVoiceMessage = true
_mediaPlayerSeekBarPositionMsg.emit(msg)
}
}
}

delay(SEEKBAR_UPDATE_DELAY)
delay(SEEKBAR_UPDATE_DELAY.milliseconds)
}
}
}
Expand Down Expand Up @@ -243,23 +249,27 @@ class MediaPlayerManager : LifecycleAwareManager {
fun setPlayBackSpeed(speed: PlaybackSpeed) {
requestedPlaybackSpeed = speed
if (mediaPlayer != null && mediaPlayer!!.isPlaying) {
mediaPlayer!!.playbackParams.let { params ->
params.speed = speed.value
mediaPlayer!!.playbackParams = params
}
mediaPlayer!!.playbackParameters = PlaybackParameters(speed.value)
}
}

private fun init(path: String) {
try {
mediaPlayer = MediaPlayer().apply {
val context = NextcloudTalkApplication.sharedApplication!!.applicationContext
mediaPlayer = ExoPlayer.Builder(context).build().apply {
_managerState.value = MediaPlayerManagerState.SETUP
setDataSource(path)
setMediaItem(MediaItem.fromUri(path))
currentDataSource = path
prepareAsync()
setOnPreparedListener {
onPrepare()
}
prepare()
addListener(object : Player.Listener {
override fun onPlaybackStateChanged(playbackState: Int) {
if (playbackState == Player.STATE_READY &&
_managerState.value == MediaPlayerManagerState.SETUP
) {
onPrepare()
}
}
})
}
} catch (e: Exception) {
Log.e(ChatActivity.TAG, "failed to initialize mediaPlayer", e)
Expand All @@ -269,67 +279,72 @@ class MediaPlayerManager : LifecycleAwareManager {

private fun initCycling() {
try {
mediaPlayer = MediaPlayer().apply {
val context = NextcloudTalkApplication.sharedApplication!!.applicationContext
mediaPlayer = ExoPlayer.Builder(context).build().apply {
_managerState.value = MediaPlayerManagerState.SETUP
val pair = playQueue.iterator().next()
setDataSource(pair.first)
setMediaItem(MediaItem.fromUri(pair.first))
currentDataSource = pair.first
_currentCycledMessage.value = pair.second
playQueue.removeAt(0)
prepareAsync()
setOnPreparedListener {
onPrepare()
}

setOnCompletionListener {
if (playQueue.iterator().hasNext() && playQueue.first().first != currentDataSource) {
_managerState.value = MediaPlayerManagerState.SETUP
val nextPair = playQueue.iterator().next()
playQueue.removeAt(0)
mediaPlayer?.reset()
mediaPlayer?.setDataSource(nextPair.first)
_currentCycledMessage.value = nextPair.second
prepare()
} else {
mediaPlayer?.release()
mediaPlayer = null
_backgroundPlayUIFlow.tryEmit(null)
_currentCycledMessage.value?.let {
it.resetVoiceMessage = true
it.isPlayingVoiceMessage = false
it.voiceMessageSeekbarProgress = 0
it.voiceMessagePlayedSeconds = 0
}
val completedMessage = _currentCycledMessage.value
_currentCycledMessage.value = null
if (completedMessage != null) {
scope.launch {
_mediaPlayerSeekBarPositionMsg.emit(completedMessage)
prepare()
addListener(object : Player.Listener {
override fun onPlaybackStateChanged(playbackState: Int) {
if (playbackState == Player.STATE_READY &&
_managerState.value == MediaPlayerManagerState.SETUP
) {
onPrepare()
} else if (playbackState == Player.STATE_ENDED) {
if (playQueue.iterator().hasNext() && playQueue.first().first != currentDataSource) {
_managerState.value = MediaPlayerManagerState.SETUP
val nextPair = playQueue.iterator().next()
playQueue.removeAt(0)
mediaPlayer?.setMediaItem(MediaItem.fromUri(nextPair.first))
currentDataSource = nextPair.first
_currentCycledMessage.value = nextPair.second
prepare()
} else {
mediaPlayer?.release()
mediaPlayer = null
_backgroundPlayUIFlow.tryEmit(null)
_currentCycledMessage.value?.let {
it.resetVoiceMessage = true
it.isPlayingVoiceMessage = false
it.voiceMessageSeekbarProgress = 0
it.voiceMessagePlayedSeconds = 0
}
val completedMessage = _currentCycledMessage.value
_currentCycledMessage.value = null
if (completedMessage != null) {
scope.launch {
_mediaPlayerSeekBarPositionMsg.emit(completedMessage)
}
}
loop = false
_managerState.value = MediaPlayerManagerState.STOPPED
}
}
loop = false
_managerState.value = MediaPlayerManagerState.STOPPED
}
}
})
}
} catch (e: Exception) {
Log.e(ChatActivity.TAG, "failed to initialize mediaPlayer", e)
_managerState.value = MediaPlayerManagerState.ERROR
}
}

private fun MediaPlayer.onPrepare() {
mediaPlayerDuration = this.duration
private fun ExoPlayer.onPrepare() {
mediaPlayerDuration = this.duration.toInt()

val playBackSpeed = requestedPlaybackSpeed?.value
?: if (_currentCycledMessage.value?.actorId == null) {
PlaybackSpeed.NORMAL.value
} else {
appPreferences.getPreferredPlayback(_currentCycledMessage.value?.actorId).value
}
mediaPlayer!!.playbackParams = mediaPlayer!!.playbackParams.setSpeed(playBackSpeed)
playbackParameters = PlaybackParameters(playBackSpeed)

start()
play()
_managerState.value = MediaPlayerManagerState.STARTED
_currentCycledMessage.value?.let {
it.isPlayingVoiceMessage = true
Expand Down
36 changes: 36 additions & 0 deletions app/src/main/java/com/nextcloud/talk/chat/data/io/VoiceMessageMediaService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
/*
* Nextcloud Talk - Android Client
*
* SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: GPL-3.0-or-later
*/

package com.nextcloud.talk.chat.data.io

import androidx.annotation.OptIn
import androidx.media3.common.util.UnstableApi
import androidx.media3.exoplayer.ExoPlayer
import androidx.media3.session.MediaSession
import androidx.media3.session.MediaSessionService

class VoiceMessageMediaService : MediaSessionService() {
private var mediaSession: MediaSession? = null

@OptIn(UnstableApi::class)
override fun onCreate() {
super.onCreate()
val player = ExoPlayer.Builder(this).build()
mediaSession = MediaSession.Builder(this, player).build()
}

override fun onGetSession(controllerInfo: MediaSession.ControllerInfo): MediaSession? {
return mediaSession
}

override fun onDestroy() {
mediaSession?.player?.release()
mediaSession?.release()
mediaSession = null
super.onDestroy()
}
}
3 changes: 3 additions & 0 deletions app/src/main/java/com/nextcloud/talk/chat/viewmodels/ChatViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -854,7 +854,10 @@ class ChatViewModel @AssistedInject constructor(
}
}

var currentVoiceMessage: ChatMessage? = null

fun syncVoiceMessageUiState(message: ChatMessage) {
currentVoiceMessage = message
_uiState.update { current ->
val updatedItems = current.items.map { item ->
if (item is ChatItem.MessageItem && item.uiMessage.id == message.jsonMessageId) {
Expand Down
Loading
Loading