Merged
Conversation
Using a numeric value like "100" as array-key automatically casts it to an integer. The type cast ensures the userId is a string as required by printRecord. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Collaborator
Author
|
/backport to stable33 |
There was a problem hiding this comment.
Pull request overview
This PR fixes a TypeError that occurs when userIds are numeric strings (e.g., "100"). PHP automatically casts numeric string array keys to integers, which causes a type mismatch when the userId is passed to the printRecord method that requires a string parameter. The fix adds an explicit string cast to ensure type safety.
Changes:
- Added explicit string cast when passing userId to printRecord method to prevent TypeError with numeric userIds
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a numeric value like "100" as array-key automatically casts it to an integer. The type cast ensures the userId is a string as required by printRecord.