-
Notifications
You must be signed in to change notification settings - Fork 1
Resolve hanging build for ubuntu-22.04 and macos-13 #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
f1a0077 to
c738256
Compare
`devel/build` was hanging and failing for ubuntu-22.04 and macos-13 in the CI workflow, but succeeded for macos-14. The downgrade of `awscli` in the successful macos-14 summary looked suspicious, so I decided to pin `awscli >=2` to see if it resolved the hanging issue and it did!¹ Still not sure _why_ this worked, but I'm guessing there was some weird dependency resolution during `boa build`. ¹ <#105 (comment)>
Although the previous commit solved the `devel/build` hanging issue, the test install of the package with `micromamba create` failed for ubuntu-22.04 with an error for the `_x86_64-microarch-level` dependency.¹ Threads on similar errors indicated that there was a mismatch in how mamba and conda report the microarch,² so I removed the `_x86_64-microarch-level` dependency in the locked/recipe.yaml and it resolved the error in the CI workflow.³ ¹ <#105 (comment)> ² <#105 (comment)> ³ <#105 (comment)>
Output the `micromamba` version used in the CI workflow so we can debug any errors in the CI workflow with the same version locally.
This is needed for the CI workflow to complete successfully until nextstrain/cli#430 is merged and released.
This was referenced Apr 29, 2025
Contributor
Author
|
Closing in favor of #111 |
tsibley
pushed a commit
that referenced
this pull request
May 8, 2025
Avoids x86_64-microarch-level versions >1 which otherwise get resolved and pinned because the build machine (e.g. CI's GitHub Actions runner) has hardware which supports greater x86_64 microarch levels. Setting this in ./devel/build for the same reasons we set CONDA_SUBDIR there: it makes local development more similar to CI. Due to the nature of our meta-package, we need to adjust the virtual __archspec (i.e. what the machine is capable of) instead of using recipe build dependencies on x86_64-microarch-level. See discussion in links below. See-also: <#111> Resolves: <#105> Related-to: <#108> Co-authored-by: Jover Lee <joverlee521@gmail.com>
tsibley
added a commit
that referenced
this pull request
May 8, 2025
Avoids x86_64-microarch-level versions >1 which otherwise get resolved and pinned because the build machine (e.g. CI's GitHub Actions runner) has hardware which supports greater x86_64 microarch levels. Setting this in ./devel/build for the same reasons we set CONDA_SUBDIR there: it makes local development more similar to CI. Due to the nature of our meta-package, we need to adjust the virtual __archspec (i.e. what the machine is capable of) instead of using recipe build dependencies on x86_64-microarch-level. See discussion in links below. See-also: <#111> Resolves: <#105> Related-to: <#108> Co-authored-by: Jover Lee <joverlee521@gmail.com>
tsibley
added a commit
that referenced
this pull request
May 8, 2025
Avoids x86_64-microarch-level versions >1 which otherwise get resolved and pinned because the build machine (e.g. CI's GitHub Actions runner) has hardware which supports greater x86_64 microarch levels. Setting this in ./devel/build for the same reasons we set CONDA_SUBDIR there: it makes local development more similar to CI. Due to the nature of our meta-package, we need to adjust the virtual __archspec (i.e. what the machine is capable of) instead of using recipe build dependencies on x86_64-microarch-level. See discussion in links below. See-also: <#111> Resolves: <#105> Related-to: <#108> Co-authored-by: Jover Lee <joverlee521@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Depends on the merge and release of nextstrain/cli#430
I'm still not entirely sure why the build was hanging, but this seems to resolve the issue:
awscli >=2_x86_64-microarch-levelfrom locked/recipe.yaml to work around installation error on ubuntu-22.04Related issue(s)
Resolves #105
Checklist