feat(sys): import types from other -sys crates#173
Draft
bavshin-f5 wants to merge 4 commits intonginx:mainfrom
Draft
feat(sys): import types from other -sys crates#173bavshin-f5 wants to merge 4 commits intonginx:mainfrom
bavshin-f5 wants to merge 4 commits intonginx:mainfrom
Conversation
Leave only NGINX code and referenced types.
The change introduces an optional feature nginx-sys/openssl-sys that replaces some generated types with corresponding imports from "libc".
The change introduces an optional feature nginx-sys/libc that replaces some generated types with corresponding imports from "libc".
The change introduces an optional feature nginx-sys/pcre2-sys that replaces some generated types with corresponding imports from "pcre2-sys".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, bindgen generates bindings for everything we include: OpenSSL, PCRE2, system headers. This approach has several drawbacks:
*mut nginx_sys::SSL_CTXis not the same type as*mut openssl_sys::SSL_CTXand requires unchecked pointer casts.The code here attempts to solve this by blocklisting and replacing the external library types with types from
libc,openssl-sysandpcre2-sys.TODOs:
expand_definitionsoutput to figure out what we can and should import.Bonus: since we're introducing a
bindgen::callbacks::ParseCallbacksimplementation, we can also start adjusting the types forNGX_OK/ERROR/etc...viaParseCallbacks::int_macro().Fixes: #99