Open
Conversation
22fdab4 to
a2ecf0c
Compare
To reduce some confusion. Since this example was introduced, we introduced a smaller nginx-native async executor directly to ngx
because the windows nmake program doesn't support .PHONY, and therefore it may reuse stale items from the cache instead of building them
a2ecf0c to
4043c1f
Compare
8c315b7 to
0eb092f
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
asyncexample totokio. Its still fine to use tokio with ngx, but since this example was written we added an async executor to ngx that uses the nginx event loop, rather than using tokio in another thread.tokioexample namedasyncwhere we remove all use of tokio, and replace it with ngx::async.Checklist
Before creating a PR, run through this checklist and mark each as complete.