feat: module of utilities for integration tests#74
feat: module of utilities for integration tests#74JyJyJcr wants to merge 3 commits intonginx:mainfrom
Conversation
|
Hi there, once again thank you for all of your contributions. I talked over this PR with some of the other project maintainers and there is a strong opinion that this functionality may be better in another project/library that supplements |
|
Of course possible (and I agree to split it from the core), but before changing let me clarify which is better, creating a new GitHub repository, or just separating it into a new subdirectory in this repository, just like |
There's It's also optional and could be omitted by the buildsystem if you specify an empty --prefix (we do that for the official Windows builds), but that's only a problem with non-vendored Nginx source tree. |
Thank you for important information. Now |
Splitting the module to another project could cause incompatible (different version) two indirect dependencies to |
615c13c to
0e76ad8
Compare
Proposed changes
This PR adds
test_utilmodule, utilities for integration tests of Nginx modules. The utilities were moved fromtests/log_test.rs, and fixed to use the bundled Nginx used in bindings, the install path of which is recorded innginx-sys::metadata::NGINX_INSTALL_DIR.Checklist
Before creating a PR, run through this checklist and mark each as complete.