Skip to content

Fix nullable entity comparison with null and implicit/cross joins #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fredericDelaporte merged 2 commits into from
Aug 11, 2021
Merged

Fix nullable entity comparison with null and implicit/cross joins #2891

fredericDelaporte merged 2 commits into from
Aug 11, 2021

Conversation

@bahusoid
Copy link
Member

@bahusoid bahusoid commented Aug 11, 2021 •
edited
Loading

One more adjustment is required in #2889 to handle properly queries with other joins present.

It might confuse our SqlGenereator and make it generate invalid SQL like:

, left join Entity e... -- left join starts with coma

@fredericDelaporte fredericDelaporte added this to the 5.3.10 milestone Aug 11, 2021
@fredericDelaporte fredericDelaporte merged commit d3f1323 into nhibernate:5.3.x Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hazzik hazzik hazzik approved these changes

Assignees

No one assigned

Labels

c: Core p: Minor r: Fixed t: Bug

Projects

None yet

Milestone

5.3.10

Development

Successfully merging this pull request may close these issues.

3 participants

@bahusoid @hazzik @fredericDelaporte