Skip to content
This repository was archived by the owner on Sep 26, 2025. It is now read-only.

Comments

chore: update schemas#981

Merged
dbarrosop merged 1 commit intomainfrom
sadq23
Aug 26, 2025
Merged

chore: update schemas#981
dbarrosop merged 1 commit intomainfrom
sadq23

Conversation

@dbarrosop
Copy link
Member

@dbarrosop dbarrosop commented Aug 26, 2025

PR Type

Enhancement


Description

  • Add Entra ID OAuth provider configuration

  • Update dependency to latest version

  • Include provider in test configurations


Diagram Walkthrough

flowchart LR
  A["Config Files"] --> B["Add Entraid Provider"]
  B --> C["Test Files"]
  B --> D["Docker Compose"]
  E["Dependencies"] --> F["Update nhost/be"]
Loading

File Walkthrough

Relevant files
Enhancement
example.go
Add Entraid provider example configuration                             

cmd/config/example.go

  • Add Entraid OAuth provider configuration example
  • Include ClientId, ClientSecret, Enabled, and Tenant fields
+6/-0     
Tests
validate_test.go
Include Entraid in validation tests                                           

cmd/config/validate_test.go

  • Add Entraid provider to expected configuration
  • Set default disabled state with common tenant
+4/-0     
auth_test.go
Add Entraid Docker environment variables                                 

dockercompose/auth_test.go

  • Add Entraid environment variables for Docker Compose
  • Include CLIENT_ID, CLIENT_SECRET, ENABLED, and TENANT vars
+4/-0     
main_test.go
Include Entraid in main test config                                           

dockercompose/main_test.go

  • Add Entraid OAuth provider to main configuration
  • Configure with client credentials and tenant settings
+6/-0     
Dependencies
go.mod
Update nhost/be dependency version                                             

go.mod

  • Update nhost/be dependency to newer version
  • Change from 072ba750534a to 51f349e46355
+1/-1     
go.sum
Update dependency checksums                                                           

go.sum

  • Add new checksum for updated nhost/be dependency
  • Include both old and new version checksums
+2/-0     

@github-actions
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Configuration Mismatch

The Entraid configuration in the test uses a hardcoded tenant value "common" instead of using the same pattern as the example configuration which uses "entraidTenant". This inconsistency could lead to test failures or incorrect validation behavior.

Entraid: &model.ConfigAuthMethodOauthEntraid{
	Enabled: ptr(false),
	Tenant:  ptr("common"),
},

@github-actions
Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@dbarrosop dbarrosop merged commit 3467797 into main Aug 26, 2025
10 checks passed
@dbarrosop dbarrosop deleted the sadq23 branch August 26, 2025 13:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants