Add React wrappers for OK FV components#3012
Draft
fredvisser wants to merge 5 commits into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
Adds React entry points in @ni/ok-react for existing OK FV web components, enabling React consumers to use the same component surface while preserving the underlying web-component implementation.
Changes:
- Added React wrapper exports for FV card, chip selector, context help, master-detail list + item, split button (+ anchor), and summary panel (+ tile).
- Re-exported component tags and relevant public APIs from
@ni/ok-components. - Added typed React callback prop mappings for several underlying custom events.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react-workspace/ok-react/src/fv/card/index.ts | Adds React wrapper entry point for ok-fv-card and re-exports appearance/interaction APIs. |
| packages/react-workspace/ok-react/src/fv/chip-selector/index.ts | Adds React wrapper for ok-fv-chip-selector and maps the change custom event to a typed callback prop. |
| packages/react-workspace/ok-react/src/fv/context-help/index.ts | Adds React wrapper entry point for ok-fv-context-help and re-exports severity type. |
| packages/react-workspace/ok-react/src/fv/master-detail-list/index.ts | Adds React wrapper for ok-fv-master-detail-list and maps the change custom event to a typed callback prop. |
| packages/react-workspace/ok-react/src/fv/master-detail-list-item/index.ts | Adds React wrapper entry point for ok-fv-master-detail-list-item. |
| packages/react-workspace/ok-react/src/fv/split-button/index.ts | Adds React wrapper for ok-fv-split-button and maps trigger/toggle events to typed callback props. |
| packages/react-workspace/ok-react/src/fv/split-button-anchor/index.ts | Adds React wrapper for ok-fv-split-button-anchor and maps trigger/toggle events to typed callback props. |
| packages/react-workspace/ok-react/src/fv/summary-panel/index.ts | Adds React wrapper for ok-fv-summary-panel and maps the edit-items event to a typed callback prop. |
| packages/react-workspace/ok-react/src/fv/summary-panel-tile/index.ts | Adds React wrapper entry point for ok-fv-summary-panel-tile and re-exports text-position API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Adds React entry points for existing OK FV web components so React consumers can use the same supported component surface as other framework wrappers.
👩💻 Implementation
@lit/reactwrappers for card, chip selector, context help, master-detail list and list item, split button and anchor, and summary panel/tile.🧪 Testing
npm run lint -w @ni/ok-reactnpm run build -w @ni/ok-reactNo automated runtime tests were added because this focused wrapper addition follows the existing
ok-reactpackage pattern, which does not currently provide a test harness.✅ Checklist