fix(WaitForProcessing): Shutdown option WaitForProcessing never entered on subscription close
#1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in googleapis#2117, the condition to enter the
WaitForProcessingclosing behavior of a subscription was checking against anundefinedfield.isEmptyof the inventory instead of checking for theisEmpty()method of the inventory.In unit tests this went unnoticed since the field was set accordingly in the class under test.
This implicitly changes the default behavior of the subscription close functionality since the previous PR that introduced this functionality (googleapis#2068) changed the default behavior without effect as the condition was never entered during
close().Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes googleapis#2117 🦕