Skip to content

Conversation

@nico-kn
Copy link
Owner

@nico-kn nico-kn commented Dec 9, 2025

As outlined in googleapis#2117, the condition to enter the WaitForProcessing closing behavior of a subscription was checking against an undefined field .isEmpty of the inventory instead of checking for the isEmpty() method of the inventory.

In unit tests this went unnoticed since the field was set accordingly in the class under test.

This implicitly changes the default behavior of the subscription close functionality since the previous PR that introduced this functionality (googleapis#2068) changed the default behavior without effect as the condition was never entered during close().


Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes googleapis#2117 🦕

@nico-kn
Copy link
Owner Author

nico-kn commented Dec 9, 2025

Closing in favor of googleapis#2118 on the base repo

@nico-kn nico-kn closed this Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shutdown option WaitForProcessing never entered on subscription close

2 participants