Replace anonymous function by IteratorIterator#82
Open
PCouaillier wants to merge 1 commit intonikic:masterfrom
Open
Replace anonymous function by IteratorIterator#82PCouaillier wants to merge 1 commit intonikic:masterfrom
PCouaillier wants to merge 1 commit intonikic:masterfrom
Conversation
|
I guess it's because you can only pass an object to
|
Author
|
The previous lines already check the fact that it is not an array if (\is_array($iterable)) {
return new \ArrayIterator($iterable);
}
if ($iterable instanceof \Iterator) {
return $iterable;
}
if ($iterable instanceof \IteratorAggregate) {
return $iterable->getIterator();
} |
|
Fair enough, didn't see that part when I wrote the comment. Ignore my feedback then :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Is there any reason to prefer the anonymous function than the IteratorIterator ?