Update path for pc file installation#121
Open
Spritaro wants to merge 1 commit intonimbuscontrols:masterfrom
Open
Update path for pc file installation#121Spritaro wants to merge 1 commit intonimbuscontrols:masterfrom
Spritaro wants to merge 1 commit intonimbuscontrols:masterfrom
Conversation
Author
|
Dear Maintainers, Thank you so much for your awesome project! I just wanted to follow up on the PR that I submitted recently. I was wondering if anyone has had a chance to review it or if there's any additional information I can provide. For reference, it's related to #95. Best regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the path for the pc file to ensure it is correctly installed from a subdirectory.
Currently, the
installcommand installs theEIPScanner.pcfile fromCMAKE_BINARY_DIR. However, the configure_file command generates this file relative toCMAKE_CURRENT_BINARY_DIR. This causes cmake error during installation when the library is included in other projects viaadd_subdirectory.To solve this, the
installcommand has been modified to useCMAKE_CURRENT_BINARY_DIRinstead ofCMAKE_BINARY_DIRfor theEIPScanner.pcfile.