Conversation
Frodox
requested changes
Aug 11, 2018
Collaborator
Frodox
left a comment
Frodox
left a comment
There was a problem hiding this comment.
Всё хорошо, кроме вот маленькой мелочи с безопасностью :)
|
|
||
| def __init__(self): | ||
| try: | ||
| self.conn = pg.connect(host="localhost", database="shop_data", user="py_user", password="py_pass", port=6789) |
Collaborator
There was a problem hiding this comment.
давай креды только из файла всё таки читать, а не хардкодить)
| try: | ||
| self.conn = pg.connect(host="localhost", database="shop_data", user="py_user", password="py_pass", port=6789) | ||
| except pg.Error as e: | ||
| print("I'm unable to connect to the db") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Домашняя работа к 6 уроку. Скрипт временно создает таблицы в базе данных shop_data, создает записи в таблицах, а затем берет эти данные и записывает в файл output.csv в формате csv, после удаляет все созданные таблицы(осторожно, таблицы после выполнения скрипта будут удалены, даже если эти таблицы сущестовали ранее).