Merged
Conversation
|
@hi-ogawa is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
This was referenced Oct 16, 2025
hi-ogawa
added a commit
to hi-ogawa/vite-plugins
that referenced
this pull request
Oct 16, 2025
See updated readme / docs. This reduces the need of accessing `@hiogawa/vite-plugin-fullstack/runtime`. This would help when internalizing entire plugin inside Nitro - nitrojs/nitro#3662
hi-ogawa
force-pushed
the
10-05-feat_vite_add_experimental.ssrassets_for_assets_query_import
branch
from
62cc20b to
e9c0cff
Compare
hi-ogawa
added a commit
to hi-ogawa/vite-plugins
that referenced
this pull request
Oct 16, 2025
We can inject its own `vite-plugin-fullstack/types` inside `vite-plugin-fullstack`. This also reduce the need of accessing `vite-plugin-fullstack/types` for many cases. This would help when internalizing entire plugin inside Nitro - nitrojs/nitro#3662 --- Hmm, it doesn't look like this is actually helping for Nitro.
hi-ogawa
added a commit
to hi-ogawa/nitro-vite-examples
that referenced
this pull request
Oct 16, 2025
hi-ogawa
changed the title
experimental.assetsImport option?assets import
2 tasks
hi-ogawa
added a commit
to hi-ogawa/vite-plugins
that referenced
this pull request
Oct 16, 2025
This allows a way to avoid rather inflexible `buildApp` hook and let users / downstream integration to invoke `writeAssetsManifest` at the appropriate timing. This will help nitrojs/nitro#3662 ## todo - [x] docs - [x] tests
hi-ogawa
added a commit
to hi-ogawa/vite-plugins
that referenced
this pull request
Oct 16, 2025
This is nice for dynamic client entry, but this can be disabled for Nitro for now to avoid a slightly annoying log when the app is server only nitrojs/nitro#3662 ``` ◐ Building [Client] nitro 12:51:18 AM vite v7.1.10 building for production... ✓ 1 modules transformed. Generated an empty chunk: "__fallback". ✓ built in 23ms ```
…or_assets_query_import
hi-ogawa
deleted the
10-05-feat_vite_add_experimental.ssrassets_for_assets_query_import
branch
hi-ogawa
added a commit
to hi-ogawa/vite-plugin-fullstack
that referenced
this pull request
Dec 18, 2025
See updated readme / docs. This reduces the need of accessing `@hiogawa/vite-plugin-fullstack/runtime`. This would help when internalizing entire plugin inside Nitro - nitrojs/nitro#3662
hi-ogawa
added a commit
to hi-ogawa/vite-plugin-fullstack
that referenced
this pull request
Dec 18, 2025
We can inject its own `vite-plugin-fullstack/types` inside `vite-plugin-fullstack`. This also reduce the need of accessing `vite-plugin-fullstack/types` for many cases. This would help when internalizing entire plugin inside Nitro - nitrojs/nitro#3662 --- Hmm, it doesn't look like this is actually helping for Nitro.
hi-ogawa
added a commit
to hi-ogawa/vite-plugin-fullstack
that referenced
this pull request
Dec 18, 2025
This allows a way to avoid rather inflexible `buildApp` hook and let users / downstream integration to invoke `writeAssetsManifest` at the appropriate timing. This will help nitrojs/nitro#3662 ## todo - [x] docs - [x] tests
hi-ogawa
added a commit
to hi-ogawa/vite-plugin-fullstack
that referenced
this pull request
Dec 18, 2025
This is nice for dynamic client entry, but this can be disabled for Nitro for now to avoid a slightly annoying log when the app is server only nitrojs/nitro#3662 ``` ◐ Building [Client] nitro 12:51:18 AM vite v7.1.10 building for production... ✓ 1 modules transformed. Generated an empty chunk: "__fallback". ✓ built in 23ms ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
This PR add
?assetsimport support proposed in vitejs/vite#20913. It's enabled by default but addedexperimental.assetsImportto be able to disable in case something goes wrong.I tested on nitrojs/vite-examples#5 and removed
@hiogawa/vite-plugin-fullstackfrom Vue router example.I also added
examples/vite-assetsfor quick testing, but feel free to remove if it's unnecessary.📝 Checklist