fix(vite): remove noExternal: true from service environment build#3665
Merged
pi0 merged 1 commit intonitrojs:mainfrom Oct 18, 2025
Conversation
|
@hi-ogawa is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
noExternal: true from each service buildnoExternal: true from service environment build
Member
|
Looks good @hi-ogawa. Any reason still kept in draft? / also wondering should we enable externals by default for other services? |
Contributor
Author
|
Oh, I just forgot to undraft.
What do you mean? After this change, the build behavior seems good to me. Ssr environment build leaves external as is (users or framework can still specify |
pi0
approved these changes
Oct 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
I think this can be removed from each service build since final
nitroenvironment hasnoExternal: true, which can take care bundling up dependencies. Currently it's causing a large intermediate build for each service, for example in Vue Router SSR demo nitrojs/vite-examples#5, the build log shows a following:After removing
noExternal: truefrom each service (by locally patching), the build becomes:With this, the build got faster and external tracing of
nitroenvironment properly isolated runtime dependencies.output/server/node_modules, so.outputbecomes standalone output.❓ Type of change
📚 Description
📝 Checklist