Skip to content

perf: reduce type instantiations on route matching #3810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KazariEX wants to merge 3 commits into
base: v2
Choose a base branch
from
Open

perf: reduce type instantiations on route matching #3810

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b671ad
perf: reduce type instantiations on route matching
KazariEX Nov 20, 2025
57043c3
chore: lint
KazariEX Nov 20, 2025
d116bea
chore: lint
KazariEX Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 17 additions & 25 deletions src/types/fetch/_match.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,39 +58,31 @@ type CalcMatchScore<

type _MatchedRoutes<
Route extends string,
MatchedResultUnion extends MatchResult<string> = MatchResult<
keyof InternalApi
>,
> = MatchedResultUnion["key"] extends infer MatchedKeys // spread union type
? MatchedKeys extends string
? Route extends MatchedKeys
? MatchResult<MatchedKeys, true> // exact match
: MatchedKeys extends `${infer Root}/**${string}`
? MatchedKeys extends `${string}/**`
? Route extends `${Root}/${string}`
? MatchResult<MatchedKeys, false, [], true>
: never // catchAll match
: MatchResult<
MatchedKeys,
false,
CalcMatchScore<Root, Route, [], true>
> // glob match
: MatchResult<
MatchedKeys,
false,
CalcMatchScore<MatchedKeys, Route, [], true>
> // partial match
: never
MatchedKeys extends string = keyof InternalApi,
> = MatchedKeys extends any
? Route extends MatchedKeys
? MatchResult<MatchedKeys, true> // exact match
: MatchedKeys extends `${infer Root}/**${string}`
? MatchedKeys extends `${string}/**`
? Route extends `${Root}/${string}`
? MatchResult<MatchedKeys, false, [], true>
: never // catchAll match
: MatchResult<MatchedKeys, false, CalcMatchScore<Root, Route, [], true>> // glob match
: MatchResult<
MatchedKeys,
false,
CalcMatchScore<MatchedKeys, Route, [], true>
> // partial match
: never;

export type MatchedRoutes<
Route extends string,
MatchedKeysResult extends MatchResult<string> = MatchResult<
keyof InternalApi
>,
Matches extends MatchResult<string> = _MatchedRoutes<
Matches extends MatchResult<string, boolean> = _MatchedRoutes<
Route,
MatchedKeysResult
MatchedKeysResult["key"]
>,
> = Route extends "/"
? keyof InternalApi // root middleware
Expand Down
Loading