Skip to content

fix: add typeFrom support for autoimports exports generation#3963

Open
8ctavio wants to merge 2 commits intonitrojs:v2from
8ctavio:fix/imports-type-from
Open

fix: add typeFrom support for autoimports exports generation#3963
8ctavio wants to merge 2 commits intonitrojs:v2from
8ctavio:fix/imports-type-from

Conversation

@8ctavio
Copy link
Contributor

@8ctavio 8ctavio commented Jan 20, 2026

🔗 Linked issue

#3669 part 2

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

PR #3670 added imports' typeForm support for global declarations; this PR adds typeFrom support for autoimports' export statements, so that explicit imports from #imports may also find type declarations.

Inside the writeTypes function, toExports call is updated to use imports' typeFrom property when available (see unjs/unimport#477).

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@8ctavio 8ctavio requested a review from pi0 as a code owner January 20, 2026 22:35
@vercel
Copy link

vercel bot commented Jan 20, 2026

@8ctavio is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pi0 pi0 added the v2 label Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants