Allow publishing of updates to live pages to be optional#61
Open
SociologicalReview wants to merge 5 commits into
Open
Allow publishing of updates to live pages to be optional#61SociologicalReview wants to merge 5 commits into
SociologicalReview wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current version of generate_qr_code in wagtail_qrcode/wagtail_hooks.py the last two lines cause draft changes to live pages to be automatically published:
It is quite common for someone to draft changes to a page but want to hold off on publishing them, for example, if they are gradually updating a page or needing approval from another editor. Generally, it would be up to the page editor to choose when to publish a page rather than this being enforced in code.
This update introduces a setting, WAGTAIL_QR_CODE_AUTO_PUBLISH_UPDATES, which allows this behaviour to be optional.
The default is taken as False as this is more in line with common procedure.
This references issue #60