ezsp v4: fix gpepIncomingMessageHandler schema for GP frames#1
Merged
nmingam merged 2 commits intoJun 16, 2026
Merged
Conversation
Replace 5 flat address fields with EmberGpAddress struct. Fix bidirectionalInfo type Bool->uint8_t (caused parse failures).
Cover the v4 base schema (inherited by v4..v12) with the Busch-Jaeger 6716 U capture reused from the v13 tests: a direct deserialize_dict parse and an end-to-end frame_rx dispatch. Guards the EmberGpAddress struct + bidirectionalInfo uint8_t fix, and that the v4-specific EmberStatus typing accepts the captured 0x7C (EmberStatus.NO_SECURITY).
This was referenced Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the v4 base-schema fix for
gpepIncomingMessageHandlerthat this branch is missing (you invited it in zigpy#713). v4 is inherited by v4..v12.EmberGpAddressstruct andbidirectionalInfo: Bool->uint8_t, matching your v13+ fix. v4 keepsstatus: EmberStatus(v13+ moved touint8_t).BJ6716U_GPEP_PAYLOADcapture against the v4 schema end-to-end, so every EZSP version is exercised against the same real bytes - it needs nothing this branch does not already have.Targeted at your
fix-gpep-incoming-message-handlerbranch so it folds straight into zigpy#713. v4 + v13 gpep tests pass; black clean.