Contributing back changes we're using at rv#5
Open
deivid-rodriguez wants to merge 20 commits intonmoutschen:developfrom
Open
Contributing back changes we're using at rv#5deivid-rodriguez wants to merge 20 commits intonmoutschen:developfrom
rv#5deivid-rodriguez wants to merge 20 commits intonmoutschen:developfrom
Conversation
|
Thanks for the PR. It would be easier to review this if @nmoutschen merged my PR first. |
Author
|
Hei @aminya! Absolutely, it'd be better to merge your PR first, and then discuss our changes on top of that. If your PR moves forward, I'm more than happy to rebase this :) The story behind this PR is essentially:
At this point I think we'd ideally figure out how to contact @nmoutschen and see if he's interested in maintaining this repo and if not, get some more maintainers added or figure out a transition to a new home. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @nmoutschen and @aminya 👋 👋
We've been using this library in https://github.com/spinel-coop/rv for a while now, and it's working reasonably fine so far.
We've also included all the fixes in @aminya's fork, because we found them useful too ❤️.
It'd be great to join forces and give this repo some love again, so I'm proposing this PR to sync back the changes we're currently using. Although I understand you may no longer be interested since it has been a while since this repo got activity 🙏.
Anyways, thanks both for the great work!