Make the launch element choice a group to enable extensibility#7
Open
thettasch-samxl wants to merge 1 commit into
Open
Make the launch element choice a group to enable extensibility#7thettasch-samxl wants to merge 1 commit into
thettasch-samxl wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off, thank you for creating the schema! Its been hugely useful in creating/validating launch files.
When using ros2 launch with extensions (e.g. custom ros2 launch actions, example), it would be nice to somehow extend the schema to include the additionally defined elements. Currently, this is difficult/impossible to acheive (at least with XSD 1.0) without copying the whole schema and then making changes.
This PR suggests a change that allows for extension of this schema, for example by creating the following
extended_schema.xsd:The change is backwards compatible, so using just
ros2_launch.xsdshould work the same as it did before.