Skip to content

Specify repository for node.js as exclusive by default #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jkrshw wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Specify repository for node.js as exclusive by default #345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f50612
Specify repository for node.js as exclusive by default
Jan 27, 2026
19828b9
Remove config flag and always add the repository as exclusive
Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions src/main/kotlin/com/github/gradle/node/NodePlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,19 +183,23 @@ class NodePlugin : Plugin<Project> {
}

private fun addRepository(distUrl: String, allowInsecureProtocol: Boolean?) {
project.repositories.ivy {
name = "Node.js"
setUrl(distUrl)
patternLayout {
artifact("v[revision]/[artifact](-v[revision]-[classifier]).[ext]")
}
metadataSources {
artifact()
project.repositories.exclusiveContent {
forRepository {
project.repositories.ivy {
Copy link
Author

@jkrshw jkrshw Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One doubt I have is that this first adds the ivy repository to the declared repositories, and then newly added repository is passed in to project.repositories.exclusiveContent.

Looking through the gradle code that seems fine, and I couldn't find any other supported way to create an ivy repository other than through project.repositories.ivy

name = "Node.js"
setUrl(distUrl)
patternLayout {
artifact("v[revision]/[artifact](-v[revision]-[classifier]).[ext]")
}
metadataSources {
artifact()
}
allowInsecureProtocol?.let { isAllowInsecureProtocol = it }
}
}
content {
filter {
includeModule("org.nodejs", "node")
}
allowInsecureProtocol?.let { isAllowInsecureProtocol = it }
}
}

Expand Down