Conversation
| This means: | ||
| - the port defaults to 1880 but can be overridden by the `PORT` env var | ||
| - the credential secret can be provided by an env var | ||
| - the admin api (inc editor) is disabled |
There was a problem hiding this comment.
I basically agree disabled should be default... but ... Is this something that could be exposed as a "mini-settings" config as part of the Docker sidebar ? (ie in additions to docker build and push - should we expose a really limited couple of choices that users would want to change "all the time" - like Base image (default node-red-docker:latest) and this enable admin option ?
There was a problem hiding this comment.
Not as part of the Docker sidebar, but yes, the Project Settings dialog will expose both settings.js and Dockerfile so they can be edited. As a minimum, editing the raw files, but if there is a way to provide a tick-box means of setting 'common' properties, then we should do that.
The hard part of that is knowing how to apply the settings to the files themselves - especially if they have hand-edited the file.
| The design needs to consider how this sidebar could be repurposed for other build | ||
| targets in the future. For example, building an Electron-based application rather | ||
| than a Docker image. | ||
|
|
There was a problem hiding this comment.
Been looking at Electron recently - and there are potentially too many options unless we want to be really prescriptive. However - there are things we could do to help - most of which could be covered by adding fields to package.json (either to existing Node-RED section or a new electron specific section. (Things like the human friendly "productName", which screen to show first (dashboard/editor/map etc), kiosk mode, and again whether to allow admin/editing) - So again a set of minimal options to help config the export - for other tools to then pick up.
2 participants
No description provided.