Add design note for converting SUBFLOW to NPM#27
Open
HiroyasuNishiyama wants to merge 2 commits intonode-red:masterfrom
Open
Add design note for converting SUBFLOW to NPM#27HiroyasuNishiyama wants to merge 2 commits intonode-red:masterfrom
HiroyasuNishiyama wants to merge 2 commits intonode-red:masterfrom
Conversation
Member
|
This is a good start. Do you have any thoughts on how the runtime then makes use of the subflow json? That is going to be the hard part of this feature and I would like some discussion on the internal changes needed. |
Member
Author
|
My assumption is that SUBFLOW definition with |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add design note for converting SUBFLOW to NPM module.
Currently Node-RED nodes are distributed as NPM module. There is a design proposal that enable a SUBFLOW to be exported as a node in JSON format (https://github.com/node-red-hitachi/designs/blob/subflow-encryption/designs/exportable-subflow/README.md).
Even if redistributing SUBFLOW in JSON format is possible, it is useful to convert it to NPM format for the following reasons. Therefore, this design note proposes a method of converting JSON-formatted SUBFLOW nodes into NPM modules.