fix: dont check version format when binary version is specified #762
+53
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
force-pushed
the
fix/dont_check_version_format
branch
2 times, most recently
from
2f796d3 to
e6b00b8
Compare
Contributor
|
Could you try to re-use versions we already use in tests (i.e. yarn@2.2.2, pnpm@5.8.0) to limit the increase in size of the nock file? |
aduh95
force-pushed
the
fix/dont_check_version_format
branch
from
093dc2a to
e6b00b8
Compare
Contributor
Author
Done. |
Contributor
Author
|
We can ignore the timeouts (failed tests)? Because we can see timeouts frequently if we look through the git history. |
aduh95
reviewed
Nov 10, 2025
aduh95
reviewed
Nov 10, 2025
aduh95
reviewed
Nov 12, 2025
aduh95
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #760