Skip to content

chore(linter): enable neostandard semicolon mode - #1138

Merged
Renegade334 merged 1 commit into
nodejs:mainfrom
Renegade334:neostandard-semicolon-mode
Aug 5, 2026
Merged

chore(linter): enable neostandard semicolon mode#1138
Renegade334 merged 1 commit into
nodejs:mainfrom
Renegade334:neostandard-semicolon-mode

Conversation

@Renegade334

Copy link
Copy Markdown
Member

neostandard defaults to disallowing terminating semicolons, but this can be switched by passing semi: true to the neostandard initializer.

We were previously omitting this option and manually overriding the semicolon rule, but this left other semicolon linting disabled, specifically @stylistic/no-extra-semi.

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 52.50000% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.19%. Comparing base (4d967bf) to head (507da61).

Files with missing lines Patch % Lines
lib/config.js 57.14% 3 Missing ⚠️
lib/run.js 40.00% 3 Missing ⚠️
lib/links.js 50.00% 2 Missing ⚠️
lib/prepare_release.js 0.00% 2 Missing ⚠️
lib/utils.js 60.00% 2 Missing ⚠️
components/metadata.js 0.00% 1 Missing ⚠️
lib/auth.js 0.00% 1 Missing ⚠️
lib/file.js 80.00% 1 Missing ⚠️
lib/landing_session.js 0.00% 1 Missing ⚠️
lib/prepare_security.js 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1138      +/-   ##
==========================================
- Coverage   57.32%   57.19%   -0.13%     
==========================================
  Files          53       53              
  Lines       10368    10368              
==========================================
- Hits         5943     5930      -13     
- Misses       4425     4438      +13     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Renegade334
Renegade334 merged commit db1e490 into nodejs:main Aug 5, 2026
9 of 11 checks passed
@Renegade334
Renegade334 deleted the neostandard-semicolon-mode branch August 5, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants