-
-
Notifications
You must be signed in to change notification settings - Fork 34.3k
v8: add GCProfiler support for erm #61191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IlyasShabi
wants to merge
3
commits into
nodejs:main
Choose a base branch
from
IlyasShabi:ishabi/gcprofiler-erm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+40
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61191 +/- ##
==========================================
- Coverage 88.53% 88.52% -0.01%
==========================================
Files 703 704 +1
Lines 208598 208743 +145
Branches 40227 40282 +55
==========================================
+ Hits 184674 184784 +110
- Misses 15951 15978 +27
- Partials 7973 7981 +8
🚀 New features to boost your workflow:
|
Renegade334
reviewed
Dec 28, 2025
Member
Renegade334
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just needs adding to the docs!
avivkeller
approved these changes
Dec 29, 2025
lpinca
approved these changes
Jan 7, 2026
Renegade334
reviewed
Jan 9, 2026
Renegade334
reviewed
Jan 9, 2026
Renegade334
approved these changes
Jan 9, 2026
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GCProfiler support for explicit resource management