Skip to content

fs: validate statfs path #61230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Jan 3, 2026
+13 −1
Merged

fs: validate statfs path #61230

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d93ab47
fs: validate statfs path
efekrskl Dec 31, 2025
9bdcb06
fs: add test for statfs validate path
efekrskl Dec 31, 2025
4d65e94
test: update test
efekrskl Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/fs/promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1047,7 +1047,7 @@ async function stat(path, options = { bigint: false }) {

async function statfs(path, options = { bigint: false }) {
const result = await PromisePrototypeThen(
binding.statfs(path, options.bigint, kUsePromises),
binding.statfs(getValidatedPath(path), options.bigint, kUsePromises),
undefined,
handleErrorFromBinding,
);
Expand Down
15 changes: 15 additions & 0 deletions test/parallel/test-fs-promises-statfs-validate-path.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
'use strict';

const common = require('../common');
const fs = require('fs');
const assert = require('assert');

(async () => {
await assert.rejects(
fs.promises.statfs(),
(err) => {
assert.strictEqual(err.code, 'ERR_INVALID_ARG_TYPE');
return true;
}
);
})().then(common.mustCall());
Loading