Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions benchmarks/benchmark-http2.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,21 +91,23 @@ class SimpleRequest {
}).on('finish', resolve)
}

onConnect (abort) { }
onRequestStart (controller, ctx) { }

onHeaders (statusCode, headers, resume) {
this.dst.on('drain', resume)
onResponseStart (controller, statusCode, headers, statusMessage) {
this.dst.on('drain', () => controller.resume())
}

onData (chunk) {
return this.dst.write(chunk)
onResponseData (controller, chunk) {
if (!this.dst.write(chunk)) {
controller.pause()
}
}

onComplete () {
onResponseEnd (controller, trailers) {
this.dst.end()
}

onError (err) {
onResponseError (controller, err) {
throw err
}
}
Expand Down
12 changes: 6 additions & 6 deletions lib/dispatcher/client-h2.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@
}
} = http2

function noop() {}

Check failure on line 77 in lib/dispatcher/client-h2.js

View workflow job for this annotation

GitHub Actions / Lint

Missing space before function parentheses

function getGoAwayError (session, errorCode) {
return session[kError] ||
(errorCode === NGHTTP2_NO_ERROR
Expand Down Expand Up @@ -106,18 +108,18 @@
}

function bindRequestToStream (request, stream, cleanup) {
const previousCleanup = request[kRequestStreamCleanup]
const previousCleanup = request[kRequestStreamCleanup] || noop
detachRequestFromStream(request)
previousCleanup?.()
previousCleanup()
request[kRequestStreamId] = stream.id
request[kRequestStream] = stream
request[kRequestStreamCleanup] = cleanup
}

function clearRequestStream (request) {
const cleanup = request[kRequestStreamCleanup]
const cleanup = request[kRequestStreamCleanup] || noop
detachRequestFromStream(request)
cleanup?.()
cleanup()
}

function canRetryRequestAfterGoAway (request) {
Expand Down Expand Up @@ -501,8 +503,6 @@
this[kClosed] = true
}

function noop () {}

function closeStreamSession (stream) {
const session = stream[kHTTP2Session]

Expand Down
Loading