Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/dispatcher/client-h1.js
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ class Parser {
constructor (client, socket, { exports }) {
this.llhttp = exports
this.ptr = this.llhttp.llhttp_alloc(constants.TYPE.RESPONSE)
this.llhttp.llhttp_set_lenient_spaces_after_chunk_size(this.ptr, 1)
this.client = client
/**
* @type {import('net').Socket}
Expand Down
59 changes: 56 additions & 3 deletions test/parser-issues.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,17 @@ const truncatedChunkedResponse = Buffer.from(
'hel\r\n'
)

const chunkedResponseWithTrailingSpaceAfterChunkSize = Buffer.from(
'HTTP/1.1 200 OK\r\n' +
'Transfer-Encoding: chunked\r\n' +
'Connection: close\r\n' +
'\r\n' +
'7\r\n' +
'hello, \r\n' +
'0 \r\n' +
'\r\n'
)

function createTrackedServer (onConnection) {
const sockets = new Set()
const server = net.createServer(socket => {
Expand Down Expand Up @@ -255,17 +266,18 @@ test('refreshes wasm input view after reallocating parser buffer', async (t) =>
})

test('truncated chunked responses terminated by EOF error the response body', async (t) => {
const ctx = t
t = tspl(t, { plan: 3 })

const server = net.createServer((socket) => {
socket.end(truncatedChunkedResponse)
})
after(() => server.close())
ctx.after(() => server.close())

await new Promise(resolve => server.listen(0, resolve))

const client = new Client(`http://localhost:${server.address().port}`)
after(() => client.destroy())
ctx.after(() => client.destroy())

client.request({
method: 'GET',
Expand All @@ -286,13 +298,54 @@ test('truncated chunked responses terminated by EOF error the response body', as
await t.completed
})

test('accepts chunked response with spaces after chunk size', async (t) => {
const ctx = t
t = tspl(t, { plan: 2 })

const server = net.createServer((socket) => {
socket.end(chunkedResponseWithTrailingSpaceAfterChunkSize)
})
ctx.after(() => server.close())

await new Promise(resolve => server.listen(0, resolve))

const client = new Client(`http://localhost:${server.address().port}`)
ctx.after(() => client.destroy())

client.request({
method: 'GET',
path: '/'
}, (err, data) => {
t.ifError(err)
if (err) {
return
}

const chunks = []

data.body
.on('data', chunk => {
chunks.push(chunk)
})
.on('error', err => {
t.ifError(err)
})
.on('end', () => {
t.strictEqual(Buffer.concat(chunks).toString(), 'hello, ')
})
})

await t.completed
})

test('fetch rejects truncated chunked responses terminated by EOF', async (t) => {
const ctx = t
t = tspl(t, { plan: 3 })

const server = net.createServer((socket) => {
socket.end(truncatedChunkedResponse)
})
after(() => server.close())
ctx.after(() => server.close())

await new Promise(resolve => server.listen(0, resolve))

Expand Down