fix(websocket): preserve failed connection error message#5296
Closed
raashish1601 wants to merge 1 commit into
Closed
fix(websocket): preserve failed connection error message#5296raashish1601 wants to merge 1 commit into
raashish1601 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a WebSocket connection fails before a parser is available, Undici had the failure reason in
failWebsocketConnection()butWebSocket#onSocketClose()initialized the close reason from parser state only. That produced anErrorEventwith an empty message.This stores the failed-connection reason on the WebSocket handler and uses it when firing the
errorevent, setting botherror.messageand theErrorEvent.messagefield.Fixes #4735.
Validation
npm run lint -- lib/web/websocket/connection.js lib/web/websocket/websocket.js test/websocket/issue-4735.jsnpx borp --timeout 180000 -p "test/websocket/issue-4735.js"npx borp --timeout 180000 -p "test/websocket/issue-3546.js"npx borp --timeout 180000 -p "test/websocket/issue-4273.js"npm run lint