fix: replace tspl with native test context in test/examples.js#5300
Open
mcollina wants to merge 1 commit into
Open
fix: replace tspl with native test context in test/examples.js#5300mcollina wants to merge 1 commit into
mcollina wants to merge 1 commit into
Conversation
Migrate the request examples test from tspl to native Node.js test runner features (t.plan, t.assert) to fix flakiness on Windows CI. The tspl proxy reassigns the test context variable, which can cause issues with execution context resolution on Windows when combined with module-level after() calls for teardown hooks. Also fix missing after() import in test/parser-issues.js. Closes #5267
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5300 +/- ##
==========================================
- Coverage 93.26% 93.23% -0.04%
==========================================
Files 110 110
Lines 36533 36575 +42
==========================================
+ Hits 34071 34099 +28
- Misses 2462 2476 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flaky test/examples.js on Windows CI.
Changes
test/examples.jsfromtsplto native Node.js test runner features (t.plan,t.assert)afterimport intest/parser-issues.js(pre-existing lint error)Why
The
tsplproxy reassigns the test context variable (t = tspl(t, { plan: 7 })), which can cause issues with execution context resolution on Windows when combined with module-levelafter()calls for teardown hooks.This matches the pattern already used in other tests in the codebase (e.g.
test/mock-agent.js) and follows the ongoing migration from tspl to native test context.Closes #5267