Skip to content

feat(cjs-to-esm): scaffold codemod #340

Merged
AugustinMauroy merged 13 commits intofeature/cjs-to-esmfrom
cjs-to-esm
Mar 20, 2026
Merged

feat(cjs-to-esm): scaffold codemod #340
AugustinMauroy merged 13 commits intofeature/cjs-to-esmfrom
cjs-to-esm

Conversation

@AugustinMauroy
Copy link
Member

@AugustinMauroy AugustinMauroy commented Jan 21, 2026

Description

After some research on this plus spec written by @JakobJingleheimer. I'm marking this pr as ready to review.
So what does it do:

  • Setup the codemod structure
  • setupping the data sharing part
  • setuping tests without file and without running them

@AugustinMauroy AugustinMauroy mentioned this pull request Jan 22, 2026
@AugustinMauroy AugustinMauroy marked this pull request as ready for review February 2, 2026 10:26
@AugustinMauroy AugustinMauroy added the awaiting reviewer Author has responded and needs action from the reviewer label Feb 2, 2026
@AugustinMauroy AugustinMauroy changed the title feat(cjs-to-esm): introduce feat(cjs-to-esm): scaffold codemod Feb 17, 2026
@JakobJingleheimer
Copy link
Member

I think it would be better to use a feature branch as a staging area (and then merge that into main once it's ready for v0.1.0); I would name that branch cjs-to-esm (perhaps rename this one to something like cjs-to-esm/scaffold).

Aside from that, sure this is fine. I think we generally don't need to do this sort of ultra-basic PR that just stubs things 😅

@AugustinMauroy AugustinMauroy changed the base branch from main to feature/cjs-to-esm March 15, 2026 21:23
@AugustinMauroy
Copy link
Member Author

I think it would be better to use a feature branch as a staging area (and then merge that into main once it's ready for v0.1.0); I would name that branch cjs-to-esm (perhaps rename this one to something like cjs-to-esm/scaffold).

Done and make sens

Aside from that, sure this is fine. I think we generally don't need to do this sort of ultra-basic PR that just stubs things 😅

you was asking for small pr I do small pr 😎

@AugustinMauroy AugustinMauroy requested review from a team March 20, 2026 10:51
Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@AugustinMauroy AugustinMauroy merged commit 1a6d908 into feature/cjs-to-esm Mar 20, 2026
18 checks passed
@AugustinMauroy AugustinMauroy deleted the cjs-to-esm branch March 20, 2026 21:35
@JakobJingleheimer JakobJingleheimer removed the awaiting reviewer Author has responded and needs action from the reviewer label Mar 21, 2026
@JakobJingleheimer JakobJingleheimer modified the milestone: 20.x → 22.x Mar 21, 2026
@JakobJingleheimer JakobJingleheimer added this to the CJS → ESM milestone Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants