Skip to content

WIP Add WMF4 to build matrix in AppVeyor#44

Open
bergmeister wants to merge 3 commits into
nohwnd:masterfrom
bergmeister:patch-1
Open

WIP Add WMF4 to build matrix in AppVeyor#44
bergmeister wants to merge 3 commits into
nohwnd:masterfrom
bergmeister:patch-1

Conversation

@bergmeister

@bergmeister bergmeister commented Dec 18, 2018

Copy link
Copy Markdown
Contributor

Use WMF4 legacy image for testing. Although the image has been enabled, it does not seem to work, maybe it take a bit more time to be enabled.

@bergmeister bergmeister changed the title Add WMF4 to build matrix in AppVeyor WIP Add WMF4 to build matrix in AppVeyor Dec 18, 2018
@bergmeister

bergmeister commented Dec 18, 2018

Copy link
Copy Markdown
Contributor Author

@nohwnd The WMF 4 image is working now, we just need to make small adaptions for the way how Pester is being bootstrapped due to PowerShellGet and Packagemanagement not being fully available in PS v4. We could e.g. do a cinst Pester in the AppVeyor yaml for that or similar to how I do it in PSSA here
On an unrelated note: I have also requested here that Pester gets included in the next AppVeyor images.

@nohwnd

nohwnd commented Dec 19, 2018

Copy link
Copy Markdown
Owner

Sure, as long as it gets installed I don’t care how it got there :)

I saw that you asked them to include Pester, and I think I upvoted it. Thanks!

@bergmeister

bergmeister commented Dec 20, 2018

Copy link
Copy Markdown
Contributor Author

@nohwnd I fixed the Pester bootstrapping issue with the WMF 4 image but the results indicate that Assert or its tests need to be adapted for WMF4:

Tests Passed: 524, Failed: 109

@nohwnd

nohwnd commented Dec 21, 2018

Copy link
Copy Markdown
Owner

@bergmeister hmm that's weird, I remember it worked on PowerShell 2 and 5 and core, and 4 is not the weird kid in this bunch, v2 is. So I guess there is some oddity in PowerShell 4 that I don't know about (plausible), or something is wrong with the setup. I have a v4 vm, so I will test it after I pack all the christmas gifts (hopefully till 24th :D ). Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants