feat(share-pnl): drop SVG cover and use logo-cleaned PNGs#161
Merged
Conversation
The light grey SVG cover (share-image-1.svg) had a different design language from the other three and was visually inconsistent in the share library. Drop it from the cover options entirely. Replace the remaining three PNG covers with re-exported versions that no longer bake in the Nolus logo. The canvas-rendered logo from #160 now stands alone instead of overlapping a baked-in twin. images and palettes arrays shrink from 4 to 3 entries in lockstep so their indices stay aligned. imageIndex defaults to 0, which now points at the dark navy cover (was the deleted SVG).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The light grey hand-and-star SVG cover was visually inconsistent with the other three illustrations. Drops it from the cover library entirely. Replaces the remaining three covers with re-exported PNGs that no longer bake in the Nolus logo, so the canvas-rendered logo from #160 stands alone instead of overlapping a baked-in twin.
Changes
src/assets/icons/share-image-1.svg.share-image-{2,3,4}.pngwith versions exported without the baked-in Nolus logo.imagesandpalettesarrays inSharePnLDialog.vuefrom 4 entries to 3 in lockstep — indices realign so eachpalettes[i]still corresponds toimages[i].imageIndexdefaults to 0, which now points at the dark navy cover (was the deleted SVG).Verification
npm run lintcleannpm run format:checkcleannpm run buildcleannpm test760/760 passing