fix(share-pnl): group covers left, lift content block#162
Merged
Conversation
…om brand Cluster the three cover thumbnails together on the left of the dialog instead of stretching them across the row. Move the PnL hero, optional rows (entry/mark price, position size), and timestamp up by 50/30px so the bottom of the card has more clearance to the nolus.io brand line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tighten the share-PnL dialog layout: cluster the cover thumbnails on the left of the picker and shift the entire content block (PnL %, optional rows, timestamp) up so the bottom of the card no longer crowds the nolus.io brand line.
Changes
justify-between→flex-wrap justify-start gap-3. The three thumbnails now sit together at the left of the picker instead of being stretched across the dialog width.PNL_HERO_BASELINE_Y430 → 380. Moves the big+XX.XX%hero up 50px.nolus.iobrand line below it.No behavioral change to canvas rendering, font specs, palette logic, or the PNG download / Web Share path.
Verification
npm run lint,npm test, and the worker bundle via the pre-commit hook — all clean.