fix(single-lease): use stable decimals for short size in header#163
Merged
Conversation
The header's `stable` computed picked LPN decimals for shorts. For a short, `lease.amount` is the stable the user holds (USDC), not the borrowed crypto. On a BTC short, decimals 8 was being applied to a USDC base amount that uses decimals 6 — $69.98 rendered as $0.69. Use the lease.amount.ticker currency's decimals, matching what PositionSummaryWidget already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the single-lease header's size readout for short positions. On a short, `lease.amount` is denominated in the stable the user holds, not in the LPN. The header was applying LPN decimals to the stable amount, producing values 100× off — a BTC short showing $0.69 instead of $69.98 while the Summary widget directly below showed the correct figure.
Changes
Verification