Skip to content

Adding Preference for opening existing output tab on compile. #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brady-goldsworthy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding Preference for opening existing output tab on compile. #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0ae4a6
Add preference check for opening existing output tab
brady-goldsworthy Sep 14, 2021
7a52ef9
Add preference for opening existing output tab on compile
brady-goldsworthy Sep 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,10 @@ Builder = Object.assign(Builder, {
if (Builder.Preferences.reuseTab == true) {
document.querySelectorAll(".chrome-tab").forEach((e) => {
if (e.gmlFile.output != undefined || e.gmlFile.output == true) {
$gmedit["ui.ChromeTabs"].impl.setCurrentTab(e);
//Check for Preference of opening existing tab on compile
if (Builder.Preferences.openOutputTabOnCompile == true) {
$gmedit["ui.ChromeTabs"].impl.setCurrentTab(e);
}
e.childNodes.forEach((e) => { if (e.className == "chrome-tab-title") e.innerText = `Output (${Builder.GetTime(Time)})`; })
e.gmlFile.editor.session.setValue("");
Builder.Output = e.gmlFile;
Expand All @@ -78,7 +81,10 @@ Builder = Object.assign(Builder, {
if (aceEditor.session.gmlFile == this) {
aceEditor.gotoLine(aceEditor.session.getLength());
}

}

//If creating new output tab, always open it
GmlFile.openTab(Builder.Output);
}
Builder.Output.editor.session.setValue(`Compile Started: ${Builder.GetTime(Time)}\nUsing Runtime: ${Builder.Preferences.runtimeSelection}`);
Expand Down
2 changes: 2 additions & 0 deletions main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Builder = {
PreferencesElement: document.createElement("div"),
Preferences: {
reuseTab: false,
openOutputTabOnCompile: true,
saveCompile: false,
stopCompile: false,
displayLine: true,
Expand Down Expand Up @@ -226,6 +227,7 @@ Builder = {
}
Preferences.addInput(settingsGroup, "Fork Arguments", Builder.Preferences.forkArguments, (value) => { Builder.Preferences.forkArguments = value; Builder.SavePreferences(); });
Preferences.addCheckbox(settingsGroup, "Reuse Output Tab", Builder.Preferences.reuseTab, (value) => { Builder.Preferences.reuseTab = value; Builder.SavePreferences(); });
Preferences.addCheckbox(settingsGroup, "Open Existing Output Tab on Compile", Builder.Preferences.openOutputTabOnCompile, (value) => { Builder.Preferences.openOutputTabOnCompile = value; Builder.SavePreferences(); });
Preferences.addCheckbox(settingsGroup, "Save Upon Compile", Builder.Preferences.saveCompile, (value) => { Builder.Preferences.saveCompile = value; Builder.SavePreferences(); });
Preferences.addCheckbox(settingsGroup, "Stop Upon Compile", Builder.Preferences.stopCompile, (value) => { Builder.Preferences.stopCompile = value; Builder.SavePreferences(); });
Preferences.addCheckbox(settingsGroup, "Display Line After Fatal Error", Builder.Preferences.displayLine, (value) => { Builder.Preferences.displayLine = value; Builder.SavePreferences(); });
Expand Down