Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates frontend development tooling configurations, primarily focusing on Vim editor setup and language server configurations. The changes modernize the development environment by switching from NerdTree to native netrw for file browsing and replacing vim-lsc with vim-lsp for language server protocol support.
- Switched from NerdTree plugin to Vim's built-in netrw for file navigation
- Replaced vim-lsc with vim-lsp ecosystem (vim-lsp, vim-lsp-settings, asyncomplete)
- Updated mise configuration to include frontend-focused language servers and tools
- Minor documentation formatting improvements in README
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| xdg_config/mise/config.toml | Updated language server and tool configurations, adding GitHub Copilot and vtsls support |
| config/vimrc | Major refactor replacing NerdTree with netrw and vim-lsc with vim-lsp ecosystem |
| README.md | Minor formatting improvements to the apps table alignment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| nnoremap <C-l> <CMD>nohlsearch<CR><Esc> | ||
| nnoremap <space>d <CMD>new<BAR>exec 'read !git show HEAD:#'<BAR>setl bt=nofile ro<BAR>difft<BAR>winc p<BAR>difft<CR> | ||
| nnoremap <silent> <space>n <CMD>Lex<CR> | ||
| let g:netrw_banner = 0 | let g:netrw_liststyle = 3 | let g:netrw_altv = 1 | let g:netrw_winsize = -28 |
There was a problem hiding this comment.
[nitpick] Multiple variable assignments on a single line reduces readability. Consider splitting this into separate lines for better maintainability.
| let g:netrw_banner = 0 | let g:netrw_liststyle = 3 | let g:netrw_altv = 1 | let g:netrw_winsize = -28 | |
| let g:netrw_banner = 0 | |
| let g:netrw_liststyle = 3 | |
| let g:netrw_altv = 1 | |
| let g:netrw_winsize = -28 |
| nnoremap <buffer> [d <plug>(lsp-previous-diagnostic) | ||
| nnoremap <buffer> ]d <plug>(lsp-next-diagnostic) | ||
| endfunction | ||
| aug lsp_install | au! | au User lsp_buffer_enabled cal LSPSetup() | aug END |
There was a problem hiding this comment.
[nitpick] Complex autocommand group definition on a single line is hard to read. Consider using multi-line format with proper indentation for better clarity.
| aug lsp_install | au! | au User lsp_buffer_enabled cal LSPSetup() | aug END | |
| augroup lsp_install | |
| autocmd! | |
| autocmd User lsp_buffer_enabled call LSPSetup() | |
| augroup END |
No description provided.