This repository was archived by the owner on Jun 21, 2025. It is now read-only.
Open
Conversation
|
Please we need this PR, plugins loading is stuck at "Loading x plugins..." |
|
Encountered some issues with your PR, first I think it's better to load all dependencies before actual plugins, i.e: Log.Info("<---< Loading global dependencies <---<");
LoadDependencies(Paths.GlobalPlugins.Dependencies);
Log.Info("<---< Loading server dependencies <---<");
LoadDependencies(Paths.LocalPlugins.Dependencies);
Log.Info("<---< Loading global plugins <---<");
// Load plugins from the Global directory inside "configs".
LoadPlugins(Paths.GlobalPlugins);
Log.Info("<---< Loading server plugins <---<");
// Load plugins from the [Server port] directory inside "configs".
LoadPlugins(Paths.LocalPlugins);
Log.Info("<---< Load all plugins <---<");And I also think it's good to put try catch inside try
{
...........all the code of LoadPlugins..........
}
catch (Exception e)
{
Log.Error(e.ToString());
} |
|
I'm not really not sure why but putting line 145 if (missingDependencies.Count != 0)
{
Log.Error($"Failed loading plugin &2{Path.GetFileNameWithoutExtension(pluginInfo.Path)}&r, missing dependencies\n&2{string.Join("\n", missingDependencies.Select(x => "&r - &2" + x.Key + " v" + x.Value.ToString(3) + "&r"))}", "Loader");
continue;
}in the |
Lufou
added a commit
to Lufou/NwPluginAPI
that referenced
this pull request
Dec 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-plugin dependency fix
This PR fixes an issue where plugins would not load if they referenced another plugin that was not yet loaded.
The problem:
Assume the following scenario:
The following plugins are to be loaded:
Both
PluginAandPluginCdepend onPluginB.PluginBhas no dependencies.PluginA's assembly is loaded.PluginA, but fails because the dependencyPluginBis not yet found.PluginB's assembly is loaded and initialized.PluginCis loaded and starts without any issues.Changes:
PluginAPI.Loader.PluginAssemblyInformationstructInitializing (count) plugins...This way, a plugin can reference another that comes after it alphabetically and will still be initialized correctly.