Skip to content

feat: graduate 3 retro learnings, mark 9 already-applied#175

Merged
notque merged 1 commit intomainfrom
feat/retro-graduation-batch-1
Mar 26, 2026
Merged

feat: graduate 3 retro learnings, mark 9 already-applied#175
notque merged 1 commit intomainfrom
feat/retro-graduation-batch-1

Conversation

@notque
Copy link
Copy Markdown
Owner

@notque notque commented Mar 26, 2026

Summary

  • Graduate 3 mature retro learnings into permanent agent/skill anti-patterns
  • Mark 9 already-applied learnings as graduated so they stop being injected

Graduated (new edits)

  • Go agent: defer rows.Close() silently discards errors — use named return + deferred closure
  • Python agent: System pip/Python version mismatch — mandate pyenv + venv
  • /do skill: Agents dispatched without commit instructions lose their edits (Anti-Pattern 8)

Marked as graduated (no file changes needed)

Test plan

  • Verify graduated entries no longer appear in retro-knowledge injection
  • Verify anti-pattern sections read correctly in each target file
  • CI passes (lint, tests, routing-benchmark)

…pplied

Graduated into permanent knowledge:
- Go agent: defer rows.Close() silently discards errors (anti-pattern)
- Python agent: system pip/Python version mismatch (anti-pattern)
- /do skill: agents dispatched without commit instructions (anti-pattern 8)

Marked 9 entries as graduated that were already embedded:
- /do role clarity, main thread role, coordination layer pattern
- /do force routing, force priority
- /do word boundary triggers, test harness failures
- Router observability (implemented as hook)
- Philosophy audit (applied in PR #174)
@notque notque merged commit c84e973 into main Mar 26, 2026
4 checks passed
@notque notque deleted the feat/retro-graduation-batch-1 branch March 26, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant