refactor: migrate 26 skills to workflow-first ordering (Wave 1)#179
Merged
refactor: migrate 26 skills to workflow-first ordering (Wave 1)#179
Conversation
Rewrite go-testing, go-concurrency, go-error-handling, go-code-review, go-anti-patterns, and go-sapcc-conventions from constraints-first (Operator Context / Anti-Patterns / Anti-Rationalization boilerplate) to workflow-first ordering (constraints inline with reasoning at point-of-use). All frontmatter preserved unchanged. All constraints distributed inline — none deleted. Boilerplate sections removed. Domain content (anti-pattern catalogs, convention references) preserved. Part of ADR: workflow-first-skill-migration (Wave 1)
Rewrite systematic-debugging, systematic-code-review, systematic-refactoring, and test-driven-development from constraints-first to workflow-first ordering. All constraints distributed inline with reasoning at point-of-use. Boilerplate sections removed (Operator Context, Anti-Patterns, Anti-Rationalization, Capabilities & Limitations). Frontmatter unchanged. Domain content preserved. Part of ADR: workflow-first-skill-migration (Wave 1)
Rewrite pr-sync, git-commit-flow, pr-pipeline, and pr-status from constraints-first to workflow-first ordering. All constraints distributed inline with reasoning. Boilerplate removed. Frontmatter unchanged. Part of ADR: workflow-first-skill-migration (Wave 1)
Rewrite fast, quick, feature-design, feature-implement, feature-plan, feature-release, feature-validate, github-actions-check, python-quality-gate, pre-planning-discussion, create-voice, and install from constraints-first to workflow-first ordering. All constraints distributed inline with reasoning at point-of-use. Boilerplate sections removed. Frontmatter unchanged. Part of ADR: workflow-first-skill-migration (Wave 1)
Updated by generate-skill-index.py to reflect the migrated skills. Routing benchmark: 44/44 passing.
adr-consultation, agent-comparison, agent-evaluation, anti-ai-editor, batch-editor, blog-post-writer, branch-naming, code-cleanup, code-linting, codebase-analyzer Part of ADR: workflow-first-skill-migration (Waves 2-3)
codebase-overview, comment-quality, condition-based-waiting, content-calendar, content-engine, cron-job-auditor, data-analysis, decision-helper, dispatching-parallel-agents, distinctive-frontend-design Part of ADR: workflow-first-skill-migration (Waves 2-3)
do, do-parallel, docs-sync-checker, e2e-testing, endpoint-validator, fish-shell-config, forensics, frontend-slides, full-repo-review, gemini-image-generator Part of ADR: workflow-first-skill-migration (Waves 2-3)
generate-claudemd, go-pr-quality-gate, headless-cron-creator, image-auditor, image-to-video, integration-checker, joy-check, kubernetes-debugging, kubernetes-security, learn Part of ADR: workflow-first-skill-migration (Waves 2-3)
link-auditor, nano-banana-builder, pair-programming, parallel-code-review, pause-work, perses-code-review, perses-cue-schema, perses-dashboard-create, perses-dashboard-review, perses-datasource-manage Part of ADR: workflow-first-skill-migration (Waves 2-3)
perses-deploy, perses-grafana-migrate, perses-lint, perses-onboard, perses-plugin-create, perses-plugin-test, perses-project-manage, perses-query-builder, perses-variable-manage, plan-checker Part of ADR: workflow-first-skill-migration (Waves 2-3)
plan-manager, planning-with-files, plans, plant-seed, post-outliner, pptx-generator, pr-cleanup, pr-fix, pr-miner, pr-mining-coordinator Part of ADR: workflow-first-skill-migration (Waves 2-3)
pr-review-address-feedback, pre-publish-checker, professional-communication, read-only-ops, repo-value-analysis, resume-work, retro, roast, routing-table-updater, sapcc-audit Part of ADR: workflow-first-skill-migration (Waves 2-3)
sapcc-review, security-threat-model, seo-optimizer, series-planner, service-health-check, skill-composer, skill-eval, socratic-debugging, spec-writer, subagent-driven-development Part of ADR: workflow-first-skill-migration (Waves 2-3)
… 10) taxonomy-manager, testing-agents-with-subagents, testing-anti-patterns, threejs-builder, topic-brainstormer, typescript-check, universal-quality-gate, verification-before-completion, video-editing, vitest-runner Part of ADR: workflow-first-skill-migration (Waves 2-3)
…omplete) voice-orchestrator, voice-validator, with-anti-rationalization, wordpress-live-validation, wordpress-uploader, workflow-help, x-api All 107 skills in skills/ now migrated. Wave 4 (pipelines) next. Part of ADR: workflow-first-skill-migration
…tch 1) agent-upgrade, article-evaluation-pipeline, auto-pipeline, chain-composer, comprehensive-review, de-ai-pipeline, do-perspectives, doc-pipeline, domain-research, explore-pipeline Part of ADR: workflow-first-skill-migration (Wave 4)
…tch 2) feature-pipeline, github-profile-rules, hook-development-pipeline, mcp-pipeline-builder, perses-dac-pipeline, perses-plugin-pipeline, pipeline-retro, pipeline-scaffolder, pipeline-test-runner, research-pipeline Part of ADR: workflow-first-skill-migration (Wave 4)
…4 complete) research-to-article, skill-creation-pipeline, system-upgrade, systematic-debugging, systematic-refactoring, voice-calibrator, voice-writer, workflow-orchestrator All 28 pipelines now migrated. Full migration complete. Part of ADR: workflow-first-skill-migration (Wave 4)
All skills and pipelines migrated. Routing benchmark: 44/44 passing.
…-sapcc lost content comprehensive-review: Haiku truncated the 1616-line file to 143 lines. Restored from main and properly restructured with progressive disclosure: SKILL.md (564 lines) + 5 reference files (765 lines) for wave-specific agent lists and output templates. All 22 reviewer agents preserved. go-sapcc-conventions: Restored 2 lost content blocks: 1. SAP CC Rationalization Traps table (8 sapcc-specific reasoning traps) 2. NON-NEGOTIABLE enforcement framing on reference file loading Part of ADR: workflow-first-skill-migration
Update three sections to articulate the orchestrator+references pattern: - "Skills Are Self-Contained Packages": Add the orchestrator pattern explanation, token cost comparison table, and the principle that making skills shorter without adding references is content loss, not progressive disclosure. - "Workflow First, Constraints Inline": Update ordering to reflect the migration (removed Anti-Patterns section, added reasoning requirement). Add progressive disclosure as the complement to workflow-first ordering. - "Load Only What You Need": Expand progressive disclosure from a one-liner to concrete examples showing phase-conditional reference loading. Part of ADR: workflow-first-skill-migration
…ure) Apply the comprehensive-review progressive disclosure model to 5 skills that were over 500 lines with no references/: - create-voice (790→444L + 4 refs): sample collection, pattern identification, voice rules template, skill generation - pr-pipeline (709→417L + 4 refs): preflight checklist, review-fix loop, retro/ADR phases, PR templates - sapcc-review (605→269L + 2 refs): agent dispatch prompts, report template; also fixed duplicate Phase 4 - systematic-code-review (534→301L + 3 refs): severity classification, Go review patterns, receiving feedback - voice-writer (544→307L + 6 refs): joy-check rubric, grounding guide, generation checklist, validation scripts, voice infrastructure, output format Total: 19 reference files created. Zero content loss — all information preserved in either SKILL.md orchestrator or reference files.
Replace Operator Context check (Hardcoded/Default/Optional subsections) with Workflow Instructions check (Instructions section, Phase/Step numbering, Gate checkpoints). Replace CAN/CANNOT sections check with Inline Constraints check (counts "because" reasoning instances, target 5+). These old checks tested constraints-first boilerplate that was intentionally removed in the workflow-first migration.
notque
force-pushed
the
feat/workflow-first-wave-1
branch
from
2ea6120 to
e1f5a46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skills migrated
Go skills (6): go-testing, go-concurrency, go-error-handling, go-code-review, go-anti-patterns, go-sapcc-conventions
Core methodology (4): systematic-debugging, systematic-code-review, systematic-refactoring, test-driven-development
Git/PR (4): pr-sync, git-commit-flow, pr-pipeline, pr-status
Remaining force-routed (12): fast, quick, feature-design, feature-implement, feature-plan, feature-release, feature-validate, github-actions-check, python-quality-gate, pre-planning-discussion, create-voice, install
What changed per skill
ADR
adr/workflow-first-skill-migration.md— Wave 1 of 4Test plan