Skip to content

[Infra] Pin squash-only merges with PR-title messages in bootstrap - #39

Merged
DongyuZhao merged 2 commits into
mainfrom
squash-only-bootstrap
Jul 27, 2026
Merged

[Infra] Pin squash-only merges with PR-title messages in bootstrap#39
DongyuZhao merged 2 commits into
mainfrom
squash-only-bootstrap

Conversation

@DongyuZhao

Copy link
Copy Markdown
Contributor

Summary

Verification

shellcheck clean on the extracted embedded script; audit:repository and audit:ci green.

🤖 Generated with Claude Code

The bootstrap script now patches the repository merge policy before
upserting rulesets: squash is the only allowed merge method, and squash
commits take the pull request's title ("title (#N)") and description,
for direct merges and the merge queue alike. Without the explicit
PATCH, GitHub's default commit-message settings leave queue-built
squash commits titled "Merge pull request #N".

Ported from the tex-core copy (nouprax/tex-core#20). markdown-core
carries the bootstrap script only as the embedded copy in
docs/repository-setup-template.md, so the block lands there.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@DongyuZhao
DongyuZhao requested a review from a team July 27, 2026 19:56

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 59e8000a07

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/repository-setup-template.md
@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown

PR performance and binary-size diff

Benchmark execution is required; hosted-runner timing, memory, and size deltas are informational only.

Baseline: exact PR base f126d5ffb340 (successful main CI).

Performance

Runtime Workload Median Perf diff Memory Memory diff
c representative_large 6.012 ms ⚠️ +31.2% 8,560 KiB ✅ -2.1%
es deep_nesting 0.287 ms ✅ -24.0% 156,896 KiB ⚠️ +17.4%
es large_document 38.112 ms ✅ -5.0% 156,896 KiB ⚠️ +17.4%
kotlin deep_nesting 0.213 ms ⚠️ +18.3% 95,580 KiB ✅ -5.6%
kotlin large_document 28.075 ms ⚠️ +32.9% 94,008 KiB ✅ +0.8%
swift deep_nesting 0.079 ms ✅ -47.0% 26,144 KiB ✅ +0.2%
swift large_document 13.554 ms ✅ -3.9% 26,080 KiB ✅ +0.1%

Binary size

Artifact Bytes KiB Size diff
c-shared-library 501,888 490.1 ✅ 0 B (0.0%)
es-wasm 288,573 281.8 ✅ 0 B (0.0%)
kotlin-jvm-jar 312,972 305.6 ✅ 0 B (0.0%)

Head CI run

Size deltas are deterministic for identical build inputs. Performance deltas compare separate hosted runners and should be treated as directional evidence, not a pass/fail threshold.

…estly.

The live "main quality gates" ruleset carries a merge queue (SQUASH,
ALLGREEN) and a repository-admin bypass that the embedded bootstrap
recipe knew nothing about — a re-run would have stripped both. The
recipe now reproduces them behind MERGE_QUEUE / MAIN_ADMIN_BYPASS
variables defaulting to the live shape. The merge-policy wording no
longer presents the squash title/message settings as enforcement: they
are repository defaults a direct merge can edit, applied mechanically
only by merge-queue commits.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@DongyuZhao

Copy link
Copy Markdown
Contributor Author

Extended in 00abd2f: the embedded recipe now carries the live merge queue (SQUASH/ALLGREEN) and the repository-admin bypass behind MERGE_QUEUE/MAIN_ADMIN_BYPASS variables (a re-run previously would have stripped both), and the merge-policy wording now describes the squash title/message settings as repository defaults (applied mechanically by queue commits, editable on direct merges) per the review on the tex-core twin PR. The live repository settings were switched to squash-only with PR-title/description defaults via the same call.

@DongyuZhao
DongyuZhao merged commit 384e8a7 into main Jul 27, 2026
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant