-
Notifications
You must be signed in to change notification settings - Fork 4k
feat: show proxy environment variables in npm config list #8828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show proxy environment variables in npm config list #8828
Conversation
3341cf4 to
f0b2737
Compare
f0b2737 to
9c29072
Compare
68bebc0 to
4c2b641
Compare
|
This looks good. Are you comfortable enough with git to pull out the changes in the config workspace to their on commit? Our versioning is automatic based on conventional commit messages and the one for this PR doesn't fit with that change in the workspace package. It'd want to be something specific like If not we can do it but then the commit authorship wouldn't be wholly yours, if that matters to you. |
Adds proxy-related environment variables to npm config list output to help users understand their proxy configuration. Variables are checked case-insensitively to match the agent library behavior. Closes npm#4170
4c2b641 to
40be7bb
Compare
I've split this into two commits:
This allows proper versioning for the config workspace package. |
|
Thanks! The config list snapshot changes seem to be something else that fell through the cracks but they're not enough to block merging this PR. |
Fixes #4170
Description
This PR makes
pm config list display proxy-related environment variables when they are set.
Changes
Motivation
As reported in #4170,
pm config list was not showing environment variables like HTTP_PROXY, NOPROXY, etc., even though these variables affect how npm runs. This made it difficult for users to see what proxy settings their environment has and could lead to mistakes.
Testing
Manual testing confirms:
The new test case verifies that environment variables are displayed correctly.