-
-
Notifications
You must be signed in to change notification settings - Fork 237
feat(i18n,ui): add accessibility statement page #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n,ui): add accessibility statement page #1096
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR adds a public Accessibility page (app/pages/accessibility.vue) with i18n-driven content and SEO metadata, inserts an Accessibility link into the desktop footer and mobile header navigation, updates locale files and i18n schema with an Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
🧹 Nitpick comments (1)
server/middleware/canonical-redirects.global.ts (1)
17-18: Minor:/accessibilityis inserted before/about, breaking alphabetical order.The rest of the array is sorted alphabetically.
/aboutshould precede/accessibilitysince"about" < "accessibility"lexicographically.Suggested reorder
'/200.html', - '/accessibility', '/about', + '/accessibility', '/compare',
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
|
Marking this as a draft since we’ll need to revise this before merging it. Namely, we should not make a conformance claim either now or, in my opinion, the future. Reason being is that currently we are not conformant and even if we did become conformant, I don’t think we currently have the people-infrastructure to maintain conformance. As WCAG states, even if we are conformant, there’s no requirement that we claim it. I think that’s a good, honest posture to have with accessibility. I’ll make some wording suggestions over the next few days. |
…nt-page # Conflicts: # app/components/AppFooter.vue
knowler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this is good! We can iterate on the known issues section (if there are any issues that become outstanding).
|
@danielroe can you remove Spanish translations? I can send the translations later in another PR |
|
I already removed the spanish translations when I reworded it ✅ |

This PR also includes:
a11yandaccessibilitytitle (we can rename the page to a11y for short)en.json,es.jsonandes-419.jsonentries (a11y.*)