Skip to content

Conversation

@userquin
Copy link
Contributor

@userquin userquin commented Feb 6, 2026

This PR also includes:

  • add /accessibility page at nuxt.config.ts (at routeRules with prerender true)
  • add /accessibility page at canonical redirects server middleware
  • add wcag-aa level 2.1 svg icon to public folder
  • link at footer (link with text a11y and accessibility title (we can rename the page to a11y for short)
  • add en.json, es.json and es-419.json entries (a11y.*)

@vercel
Copy link

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 10, 2026 5:17pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 10, 2026 5:17pm
npmx-lunaria Ignored Ignored Feb 10, 2026 5:17pm

Request Review

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/en-GB.json Localization changed, will be marked as complete. 🔄️
lunaria/files/en-US.json Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This PR adds a public Accessibility page (app/pages/accessibility.vue) with i18n-driven content and SEO metadata, inserts an Accessibility link into the desktop footer and mobile header navigation, updates locale files and i18n schema with an a11y section, marks /accessibility to be prerendered in nuxt.config.ts, and registers the path in canonical-redirects middleware. No exported/public API signatures were changed.

Possibly related PRs

Suggested labels

front, a11y

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description is related to the changeset, covering key additions like the /accessibility page, routing configuration, footer link, and i18n entries.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (1)
server/middleware/canonical-redirects.global.ts (1)

17-18: Minor: /accessibility is inserted before /about, breaking alphabetical order.

The rest of the array is sorted alphabetically. /about should precede /accessibility since "about" < "accessibility" lexicographically.

Suggested reorder
   '/200.html',
-  '/accessibility',
   '/about',
+  '/accessibility',
   '/compare',

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

@knowler
Copy link
Contributor

knowler commented Feb 7, 2026

Marking this as a draft since we’ll need to revise this before merging it.

Namely, we should not make a conformance claim either now or, in my opinion, the future. Reason being is that currently we are not conformant and even if we did become conformant, I don’t think we currently have the people-infrastructure to maintain conformance. As WCAG states, even if we are conformant, there’s no requirement that we claim it. I think that’s a good, honest posture to have with accessibility.

I’ll make some wording suggestions over the next few days.

Copy link
Contributor

@knowler knowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this is good! We can iterate on the known issues section (if there are any issues that become outstanding).

@userquin
Copy link
Contributor Author

userquin commented Feb 10, 2026

reminder: we need to add a11y link (below privacy) on mobile menu:

image

@userquin
Copy link
Contributor Author

@danielroe can you remove Spanish translations? I can send the translations later in another PR

@danielroe
Copy link
Member

I already removed the spanish translations when I reworded it ✅

@danielroe danielroe enabled auto-merge February 10, 2026 17:18
@danielroe danielroe added this pull request to the merge queue Feb 10, 2026
Merged via the queue into npmx-dev:main with commit 5ff2b17 Feb 10, 2026
17 checks passed
@userquin userquin deleted the feat-add-a11y-statement-page branch February 10, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants